From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Phil Sainty <psainty@orcon.net.nz>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] scratch/so-long d216f81: fixup! Add so-long library
Date: Mon, 15 Apr 2019 07:55:21 -0400 [thread overview]
Message-ID: <jwvy34ci4n9.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <1e0b22f857b09f0587ea3e901420c9c6@webmail.orcon.net.nz> (Phil Sainty's message of "Mon, 15 Apr 2019 10:24:55 +1200")
>> or just don't define turn-on-so-long-minor-mode at all, which is what
>> I recommend.
>> I also recommend not to bother defining the turn-off function and let
>> users call (so-long-minor-mode -1) for the few cases where they might
>> need it.
> The actual reason for defining these functions is for the associated
> so-long-action-alist entry:
>
> (so-long-minor-mode
> "Enable so-long-minor-mode"
> turn-on-so-long-minor-mode
> turn-off-so-long-minor-mode)
BTW: How 'bout making this alist accept elements of the form
(<minor-mode> "description")?
Being a minor mode means you know how to gets its current status, how to
turn it on and how to turn it off, so you can standardize the treatment
you did for longlines-mode.
Stefan
prev parent reply other threads:[~2019-04-15 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190414125501.16807.79719@vcs0.savannah.gnu.org>
[not found] ` <20190414125502.AB90320536@vcs0.savannah.gnu.org>
2019-04-14 15:03 ` [Emacs-diffs] scratch/so-long d216f81: fixup! Add so-long library Stefan Monnier
2019-04-14 22:24 ` Phil Sainty
2019-04-15 11:55 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy34ci4n9.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=psainty@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).