From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Juanma Barranquero <lekktu@gmail.com>
Subject: Re: master f225011: ibuffer-do-isearch: don't depend on `cl-values-list' (bug#38430)
Date: Sun, 01 Dec 2019 13:29:22 -0500 [thread overview]
Message-ID: <jwvy2vvdhqx.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20191201091358.11752207E0@vcs0.savannah.gnu.org> (Juanma Barranquero's message of "Sun, 1 Dec 2019 04:13:57 -0500 (EST)")
> (cl-multiple-value-bind (hip-crowd lamers)
> - (cl-values-list
> - (ibuffer-split-list (lambda (bufmark)
> - (ibuffer-included-in-filters-p (car bufmark)
> - filterset))
> - bmarklist))
> + (ibuffer-split-list (lambda (bufmark)
> + (ibuffer-included-in-filters-p (car bufmark)
> + filterset))
> + bmarklist)
This is "broken" in the sense that it makes assumptions about how the
"multiple values" are implemented.
We do know that `ibuffer-split-list` returns a list, so there's no point
going through CL's multiple-values simulation. We should instead treat
it as a list and extract the elements with `pcase-let`
(or `cl-destructuring-bind`).
Stefan
next parent reply other threads:[~2019-12-01 18:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191201091356.26612.95511@vcs0.savannah.gnu.org>
[not found] ` <20191201091358.11752207E0@vcs0.savannah.gnu.org>
2019-12-01 18:29 ` Stefan Monnier [this message]
2019-12-01 23:36 ` master f225011: ibuffer-do-isearch: don't depend on `cl-values-list' (bug#38430) Juanma Barranquero
2019-12-02 0:39 ` Juanma Barranquero
2019-12-02 1:55 ` Stefan Monnier
2019-12-02 2:20 ` Juanma Barranquero
2019-12-02 3:40 ` Eli Zaretskii
2019-12-02 3:43 ` Juanma Barranquero
2019-12-02 15:38 ` Eli Zaretskii
2019-12-02 17:18 ` Juanma Barranquero
2019-12-02 17:40 ` Eli Zaretskii
2019-12-02 18:10 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy2vvdhqx.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).