From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: emacs-devel@gnu.org
Subject: Re: Multiple definitions of explicit-shell-file-name
Date: Thu, 16 Apr 2020 14:05:51 -0400 [thread overview]
Message-ID: <jwvy2qvcnrz.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87zhbb71u4.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 16 Apr 2020 18:54:59 +0100")
> I agree, but explicit-shell-file-name is used in contexts unrelated to
> shell.el, such as ansi-term and dired-insert-directory.
I don't consider ansi-term to be "unrelated" to shell.el, so I think
it's perfectly OK for it to (require 'shell). It might even encourage
more sharing of code between the two.
> Rather than define explicit-shell-file-name in a central place like
> simple.el, should these external users all check that the variable is
> bound first?
For `dired-insert-directory`, I'm not sure whether it's better to use
bound-and-true-p like we do now or to use something else entirely.
IOW, I'm not completely sure why it uses `explicit-shell-file-name`
instead of `shell-file-name`.
But, it's clearly OK to leave the current dired code as is.
Stefan
prev parent reply other threads:[~2020-04-16 18:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 23:58 Multiple definitions of explicit-shell-file-name Basil L. Contovounesios
2020-04-16 0:06 ` Basil L. Contovounesios
2020-04-16 5:15 ` Eli Zaretskii
2020-04-16 14:12 ` Stefan Monnier
2020-04-16 17:54 ` Basil L. Contovounesios
2020-04-16 18:05 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy2qvcnrz.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).