From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] A Setup package Date: Sat, 13 Mar 2021 14:14:34 -0500 Message-ID: References: <874kis6ots.fsf@posteo.net> <87pn186c5s.fsf@posteo.net> <87blbpk6l8.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4836"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 13 20:16:00 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lL9jz-00019t-WB for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Mar 2021 20:16:00 +0100 Original-Received: from localhost ([::1]:38010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lL9jz-0003xv-2Z for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Mar 2021 14:15:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lL9ij-0003Rf-DU for emacs-devel@gnu.org; Sat, 13 Mar 2021 14:14:41 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61550) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lL9ig-0002tM-Op for emacs-devel@gnu.org; Sat, 13 Mar 2021 14:14:40 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 30FDD4408BD; Sat, 13 Mar 2021 14:14:37 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 81E5644081E; Sat, 13 Mar 2021 14:14:35 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1615662875; bh=iwIyIRyiegXPQi5qeyZ0yXnY9k9VIwt9p7nvyZSnmsQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=X75wbo3yFmDuS7hob5MZk0w7axhlcwUnAsZEJAQY7yyX0ZSt0uO44e7ToCRPS6Mwt UFLDne/sirx/U5wGKMGtvoiP9ygIL7zkh1OlG/mpXPvNb2x4kJeIBa02xSYVLAW1iq D4/VQ8CslaSb5M0dNkq3FXiHYyz7CfBJB9D3uREgJv0xpTKCMtf1ezBsLyknNe+7Mn ddJdekkTs+NfHYkDR+lhApxm+h1qgQaadfYKkSVxTi/6d7VhwIYxMleLK9qZ9XBu6/ X+vI+bw6OUN93qn1cTk+tZd2fLee1UGG9gg8I7Ul3CNVZvUb715Jr5ElzaLsvn+0Qc s4zZl27O855Fg== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 66B38120218; Sat, 13 Mar 2021 14:14:35 -0500 (EST) In-Reply-To: <87blbpk6l8.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 11 Mar 2021 17:17:39 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266439 Archived-At: > I think all the issues should now be resolved. I just pushed a commit > adding edebug support. setup-help was moved into setup's docstring, a > lot of the macros were redefined to look more like setq, and all macros > were redefined to use keywords (for now). [ I have some further suggestions for the code, but they'll come later. ] I was about to add it to GNU ELPA, but I noticed two problems: 1- The file is missing a copyright notice and it is using the CC0 license. See the patch below to fix those issues (the copyright part reflects the fact that you consider the package as being covered by your copyright assignment and the license change is because we want to distribute all GNU ELPA packages under the GPLv3 license; you're of course perfectly free to also distribute this package under any other license you want, but we want to use the GPLv3 for the copy we distribute). 2- AFAIK you rebased (or force-pushed or something like that) your branch, which makes it painful for any"one" tracking your branch, such as elpa.git. In order for the elpa.git branch tracking your SourceHut repository to work sanely it'll be important not to rebase (or force-push...) in the future. Let me know when point 1 is fixed so I can add the package to GNU ELPA. Stefan PS: I removed the "This file is NOT part of Emacs" line because this is a bit problematic for GNU ELPA packages: they're at the same time part of Emacs (the project) and not part of Emacs (the release tarballs) ;-) diff --git a/setup.el b/setup.el index e547243340..510c599d5f 100644 --- a/setup.el +++ b/setup.el @@ -1,18 +1,25 @@ ;;; setup.el --- Helpful Configuration Macro -*- lexical-binding: t -*- +;; Copyright (C) 2021 Free Software Foundation, Inc. + ;; Author: Philip K. ;; Maintainer: Philip K. ;; Version: 0.1.0 ;; Package-Requires: ((emacs "26.1")) ;; Keywords: lisp, local -;; This file is NOT part of Emacs. -;; -;; This file is in the public domain, to the extent possible under law, -;; published under the CC0 1.0 Universal license. -;; -;; For a full copy of the CC0 license see -;; https://creativecommons.org/publicdomain/zero/1.0/legalcode +;; This package is Free Software: you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; This package is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with GNU Emacs. If not, see . ;;; Commentary: