From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/vertico 5bbddb0 03/48: add while-no-input-ignore-events Date: Mon, 05 Apr 2021 11:08:59 -0400 Message-ID: References: <20210405145429.5891.40124@vcs0.savannah.gnu.org> <20210405145439.787C5209C7@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22173"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 05 17:21:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTR2G-0005gR-3P for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Apr 2021 17:21:04 +0200 Original-Received: from localhost ([::1]:44898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTR2E-0002lo-O3 for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Apr 2021 11:21:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTQqg-0000iu-2W for emacs-devel@gnu.org; Mon, 05 Apr 2021 11:09:07 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52732) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTQqd-0005NF-KJ for emacs-devel@gnu.org; Mon, 05 Apr 2021 11:09:05 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E94A5440924; Mon, 5 Apr 2021 11:09:01 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BFD7B440912; Mon, 5 Apr 2021 11:09:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1617635340; bh=VStiVn+fz4MKGcZFKhmu91m+GjC/uhXxf+qU0gQ05GM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=C7hxMx1NA2ygAugBsX136hKptkUJ9IBNz2MbRUsA7qmBJNy8Nndr8MGMyjR405Lsy Aps8Q13VkoOs8habQtCgbk3xLuWIP/L3M4HGAtfYGI1xd6krY71kc4i4gb9BYKtr9D ViVyqx5mgTf7DDzDQpotY7zXICiEULllDs9kpmDbKp3N+3bWgKJ72z1/Xd04qwTtn0 5LBbvIijhH7SCdsy7HTMhSySzuh/pSSUmzYsP1dyc/8Dw6BxNNVRH9W6sf3fcZx05l mFINhbi7IGg+G3Zny+QVQNcUBXt6eT6+1Tg1U/mJNOrcyIo2tG/lT/Z0N8PfAj4/0J f3o1sEcJSs+8Q== Original-Received: from alfajor (104-222-126-84.cpe.teksavvy.com [104.222.126.84]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 310A2120334; Mon, 5 Apr 2021 11:09:00 -0400 (EDT) In-Reply-To: <20210405145439.787C5209C7@vcs0.savannah.gnu.org> (Stefan Monnier's message of "Mon, 5 Apr 2021 10:54:39 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267417 Archived-At: > add while-no-input-ignore-events > Thanks, @clemera [...] > "Preprocess candidates with INPUT string and METADATA." > - (pcase (while-no-input (minicomp--candidates input metadata)) > + (pcase (let ((while-no-input-ignore-events '(selection-request))) > + (while-no-input (minicomp--candidates input metadata))) I don't understand why you do that. Was the intention to add `selection-request` to `while-no-input-ignore-events`, or to remove everything else from it (which is what it does)? If so, why? Stefan