From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Daniel Mendler <mail@daniel-mendler.de>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] externals/vertico 5bbddb0 03/48: add while-no-input-ignore-events
Date: Mon, 05 Apr 2021 11:08:59 -0400 [thread overview]
Message-ID: <jwvy2dwn528.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20210405145439.787C5209C7@vcs0.savannah.gnu.org> (Stefan Monnier's message of "Mon, 5 Apr 2021 10:54:39 -0400 (EDT)")
> add while-no-input-ignore-events
> Thanks, @clemera
[...]
> "Preprocess candidates with INPUT string and METADATA."
> - (pcase (while-no-input (minicomp--candidates input metadata))
> + (pcase (let ((while-no-input-ignore-events '(selection-request)))
> + (while-no-input (minicomp--candidates input metadata)))
I don't understand why you do that.
Was the intention to add `selection-request` to `while-no-input-ignore-events`,
or to remove everything else from it (which is what it does)?
If so, why?
Stefan
next parent reply other threads:[~2021-04-05 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210405145429.5891.40124@vcs0.savannah.gnu.org>
[not found] ` <20210405145439.787C5209C7@vcs0.savannah.gnu.org>
2021-04-05 15:08 ` Stefan Monnier [this message]
2021-04-05 18:02 ` [elpa] externals/vertico 5bbddb0 03/48: add while-no-input-ignore-events Daniel Mendler
2021-04-05 19:02 ` Stefan Monnier
2021-04-05 19:25 ` Daniel Mendler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy2dwn528.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=mail@daniel-mendler.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).