From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/hyperbole faa8294 2/3: Redo hyperbole-mode; new {r} HyRolo search in match buffer Date: Thu, 29 Apr 2021 02:00:18 -0400 Message-ID: References: <20210429035707.30958.16274@vcs0.savannah.gnu.org> <20210429035709.3DF2320D0F@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26104"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Bob Weiner To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 29 08:01:30 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbzju-0006gA-MV for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Apr 2021 08:01:30 +0200 Original-Received: from localhost ([::1]:52990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbzjt-0005so-Lj for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Apr 2021 02:01:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbziw-0005OU-8n for emacs-devel@gnu.org; Thu, 29 Apr 2021 02:00:30 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbzis-0000aa-PB; Thu, 29 Apr 2021 02:00:29 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1F062100222; Thu, 29 Apr 2021 02:00:25 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7FBCD1000C4; Thu, 29 Apr 2021 02:00:19 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1619676019; bh=MbL4uWee4YOG7oVs9QLBEoSFBIVoCfDT/QaNDrJCUK0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=VMVEkFr0BMDdjEyw/DCTzuDelD1DiReGJ6NnGJZMaQ42jgKK9Ye5vfZHZQpr0xf+p mHqDsMZFDbvLHGR0jBrHOAA7U0HwO+KfGqL3bkS8S6bF1O+xePvHXYOjSz5qot0jUo CtPk7pEnteNC3u+rNMoBtgeSEUok1ZuQ5+UqvRgHbE5lv+MsJaoubn+8F/Fb88fD7/ FeFZNQNWLQGFEci+vs/EbumAc48vYy8IocKX0MQKqzRKZ4I5QNUAwTSWtO8YaXbfVT i5MdJXkwvRhofzVcv40cCHqJwI0cQSe8mtze51AKuWyPg2Qzi6lrRKiE3ORDA2nm8n 8nA0VxTMzMLYA== Original-Received: from alfajor (unknown [157.52.10.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4A42F1201C2; Thu, 29 Apr 2021 02:00:19 -0400 (EDT) In-Reply-To: <20210429035709.3DF2320D0F@vcs0.savannah.gnu.org> (ELPA Syncer's message of "Wed, 28 Apr 2021 23:57:08 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268602 Archived-At: > +(defun enable-hyperbole-mode () > + "Enable Hyperbole global minor mode." > + (interactive) The `hyperbole-mode` command already offers that functionality, so there's no point providing this as an interactive command. I'd recommend you use a "--" in the name and keep that function "internal". Also please use a "hyperbole-" prefix. > + ;; Activate hyperbole-mode > + (run-hooks 'hyperbole-mode-hook)) `define-minor-mode` runs `hyperbole-mode-hook` for you already, so this `run-hooks` will cause the hook to be run twice in a row. > :keymap hyperbole-mode-map This argument is redundant. > +(if after-init-time > + ;; Initialize Hyperbole key bindings and hooks. > + (hyperb:init) > + ;; Initialize after other key bindings are loaded at startup. > + (add-hook 'after-init-hook #'hyperb:init t)) > > ;; !! FIXME: Loading a file should not change Emacs's behavior but we > ;; need this here for awhile until can ensure Hyperbole users know to I suspect the above code and the above comment should be swapped? Stefan