From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/hyperbole faa8294 2/3: Redo hyperbole-mode; new {r} HyRolo search in match buffer Date: Thu, 29 Apr 2021 23:20:20 -0400 Message-ID: References: <20210429035707.30958.16274@vcs0.savannah.gnu.org> <20210429035709.3DF2320D0F@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4907"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lidell Mats , rswgnu@gmail.com, emacs-devel To: Robert Weiner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 30 05:21:41 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lcJin-0001B2-2H for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Apr 2021 05:21:41 +0200 Original-Received: from localhost ([::1]:51506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcJim-0008Lj-6G for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Apr 2021 23:21:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcJhe-0007Sw-7R for emacs-devel@gnu.org; Thu, 29 Apr 2021 23:20:30 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:26741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcJhY-0001Wx-U7; Thu, 29 Apr 2021 23:20:28 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 715531000C4; Thu, 29 Apr 2021 23:20:22 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CE49510020E; Thu, 29 Apr 2021 23:20:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1619752820; bh=2DsaciLawQyR6R8r/EDTPI/81JFo91z2JLMLyqCegts=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=k+Py1KC7JTl3KKhur4eSUCLlCNfYWyFIyv919dapDSVgaoQU9BHxIC0MWSmKdHI52 ieJ5kGl7ypS/zXVhnUsHr7n5f7hcPykvQhunlkcDNnUCrKWelKszPavPNZbghaVWnp r3NNf1GhXYeFfgmcQPhDVC/EjX/W1nLLq1HvtQO/ntS2+8PS/nDz4i0RmUz3rEwIvO 0ix1k0RFbpTKvsPsJlkuicKU7Q4GMqaANnk4UPnIpPdZjBzVGBfp36exc8yvvDyqs3 O4uwHQGtdzvbWnsykbf6d0SJNMQMp8xvaK5eNa+LyjMrio8VoDp0/r4LW158mVIZb9 mNaO340Lu32gw== Original-Received: from alfajor (unknown [108.161.125.61]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 823E21209A2; Thu, 29 Apr 2021 23:20:20 -0400 (EDT) In-Reply-To: (Robert Weiner's message of "Thu, 29 Apr 2021 22:35:10 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268650 Archived-At: > On your last comment, we want Hyperbole initialization deferred until after > Emacs init time, so that looks right to me. I meant that the "FIXME" comment seems to also apply to the (if after-init-time ...) code that precedes it, so the code should probably be moved to after the comment. I'm not sure that's the case, tho, so if it is not, you may want to add a comment explaining why this (if after-init-time ...) code is "harmless" (i.e. doesn't change Emacs's behavior). Stefan