From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Robert Weiner <rsw@gnu.org>
Cc: Lidell Mats <matsl@gnu.org>,
rswgnu@gmail.com, emacs-devel <emacs-devel@gnu.org>
Subject: Re: [elpa] externals/hyperbole faa8294 2/3: Redo hyperbole-mode; new {r} HyRolo search in match buffer
Date: Thu, 29 Apr 2021 23:20:20 -0400 [thread overview]
Message-ID: <jwvy2d0bgui.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CA+OMD9hWp4LSEmDeB34rfBEPDcv1pNKoTJYU5wUrOuPi9WzwcA@mail.gmail.com> (Robert Weiner's message of "Thu, 29 Apr 2021 22:35:10 -0400")
> On your last comment, we want Hyperbole initialization deferred until after
> Emacs init time, so that looks right to me.
I meant that the "FIXME" comment seems to also apply to the
(if after-init-time ...) code that precedes it, so the code should
probably be moved to after the comment.
I'm not sure that's the case, tho, so if it is not, you may want to add
a comment explaining why this (if after-init-time ...) code is
"harmless" (i.e. doesn't change Emacs's behavior).
Stefan
next prev parent reply other threads:[~2021-04-30 3:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210429035707.30958.16274@vcs0.savannah.gnu.org>
[not found] ` <20210429035709.3DF2320D0F@vcs0.savannah.gnu.org>
2021-04-29 6:00 ` [elpa] externals/hyperbole faa8294 2/3: Redo hyperbole-mode; new {r} HyRolo search in match buffer Stefan Monnier
2021-04-30 2:35 ` Robert Weiner
2021-04-30 3:20 ` Stefan Monnier [this message]
2021-05-16 20:12 ` Robert Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy2d0bgui.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=matsl@gnu.org \
--cc=rsw@gnu.org \
--cc=rswgnu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).