From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 4351722: Make shr render text with superscripts prettier Date: Sat, 20 Nov 2021 08:26:59 -0500 Message-ID: References: <20211120104249.11206.17692@vcs0.savannah.gnu.org> <20211120104250.84A13209FD@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18874"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 20 14:28:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moQQ1-0004fW-2z for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Nov 2021 14:28:37 +0100 Original-Received: from localhost ([::1]:60842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moQPy-0002q8-Uz for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Nov 2021 08:28:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44046) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moQOd-000215-3w for emacs-devel@gnu.org; Sat, 20 Nov 2021 08:27:11 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:45072) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moQOZ-0005M7-1j for emacs-devel@gnu.org; Sat, 20 Nov 2021 08:27:09 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 80DA0440A5C; Sat, 20 Nov 2021 08:27:02 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A0B6C440A4E; Sat, 20 Nov 2021 08:27:00 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1637414820; bh=3lguQ4yp4/CtBBx0Z9lJe26p1ByBmNJbKAVUwYEEyeU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=U3hr2YDw8wFyuUSRvXsbaGokV2PweqD+JGZ51gSFSq/F5/c/TxUblCyB4nCoxiB/5 bAkPde/Kb/NI02/BiXali0sdM3hPbOyLJwfmXktVc3O4URl3Cep1wGVkcmakSRog5i PlokeCVZRXwk72yJ6WbWmMdUUce+rpFQ3L81gXxZXvGl3z8kbw3bYboMHzpNKDU2qn C2o68W+2T2d18D4TVTTtSmVR1+NdWqEIm0LgZO5h7vWuwCj5FGqnczWeJFS4PAtRSk 84oBkR/74LjdYsl84SMNruNxrOGOB3GRmEpyImhVmNfVncIpu/v/57PJIGNNjmor1f pyGl5B5McJtjw== Original-Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4F3961201E4; Sat, 20 Nov 2021 08:27:00 -0500 (EST) In-Reply-To: <20211120104250.84A13209FD@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sat, 20 Nov 2021 05:42:50 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279805 Archived-At: We should share the script size (and the script's raise/lower) with the settings used in `tex-mode.el`. Stefan Lars Ingebrigtsen [2021-11-20 05:42:50] wrote: > branch: master > commit 4351722477cda59d88e5b1a90aa92cd6902021a8 > Author: Lars Ingebrigtsen > Commit: Lars Ingebrigtsen > > Make shr render text with superscripts prettier > > * lisp/net/shr.el (shr-sup): New face. > (shr-tag-sup, shr-tag-sub): Use it to make the super/subscripts > slightly smaller so that we don't get uneven line heights with > text that uses these. > --- > lisp/net/shr.el | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/lisp/net/shr.el b/lisp/net/shr.el > index 5a36f19..87bacd4 100644 > --- a/lisp/net/shr.el > +++ b/lisp/net/shr.el > @@ -183,6 +183,11 @@ temporarily blinks with this face." > "Face for elements." > :version "27.1") > > +(defface shr-sup > + '((t :height 0.8)) > + "Face for and elements." > + :version "29.1") > + > (defface shr-h1 > '((t :height 1.3 :weight bold)) > "Face for

elements." > @@ -1464,12 +1469,14 @@ ones, in case fg and bg are nil." > (defun shr-tag-sup (dom) > (let ((start (point))) > (shr-generic dom) > - (put-text-property start (point) 'display '(raise 0.2)))) > + (put-text-property start (point) 'display '(raise 0.2)) > + (add-face-text-property start (point) 'shr-sup))) > > (defun shr-tag-sub (dom) > (let ((start (point))) > (shr-generic dom) > - (put-text-property start (point) 'display '(raise -0.2)))) > + (put-text-property start (point) 'display '(raise -0.2)) > + (add-face-text-property start (point) 'shr-sup))) > > (defun shr-tag-p (dom) > (shr-ensure-paragraph)