From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 4351722: Make shr render text with superscripts prettier
Date: Sat, 20 Nov 2021 08:26:59 -0500 [thread overview]
Message-ID: <jwvy25jyn4y.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20211120104250.84A13209FD@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sat, 20 Nov 2021 05:42:50 -0500 (EST)")
We should share the script size (and the script's raise/lower) with the
settings used in `tex-mode.el`.
Stefan
Lars Ingebrigtsen [2021-11-20 05:42:50] wrote:
> branch: master
> commit 4351722477cda59d88e5b1a90aa92cd6902021a8
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
> Make shr render text with superscripts prettier
>
> * lisp/net/shr.el (shr-sup): New face.
> (shr-tag-sup, shr-tag-sub): Use it to make the super/subscripts
> slightly smaller so that we don't get uneven line heights with
> text that uses these.
> ---
> lisp/net/shr.el | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/net/shr.el b/lisp/net/shr.el
> index 5a36f19..87bacd4 100644
> --- a/lisp/net/shr.el
> +++ b/lisp/net/shr.el
> @@ -183,6 +183,11 @@ temporarily blinks with this face."
> "Face for <abbr> elements."
> :version "27.1")
>
> +(defface shr-sup
> + '((t :height 0.8))
> + "Face for <sup> and <sub> elements."
> + :version "29.1")
> +
> (defface shr-h1
> '((t :height 1.3 :weight bold))
> "Face for <h1> elements."
> @@ -1464,12 +1469,14 @@ ones, in case fg and bg are nil."
> (defun shr-tag-sup (dom)
> (let ((start (point)))
> (shr-generic dom)
> - (put-text-property start (point) 'display '(raise 0.2))))
> + (put-text-property start (point) 'display '(raise 0.2))
> + (add-face-text-property start (point) 'shr-sup)))
>
> (defun shr-tag-sub (dom)
> (let ((start (point)))
> (shr-generic dom)
> - (put-text-property start (point) 'display '(raise -0.2))))
> + (put-text-property start (point) 'display '(raise -0.2))
> + (add-face-text-property start (point) 'shr-sup)))
>
> (defun shr-tag-p (dom)
> (shr-ensure-paragraph)
next parent reply other threads:[~2021-11-20 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211120104249.11206.17692@vcs0.savannah.gnu.org>
[not found] ` <20211120104250.84A13209FD@vcs0.savannah.gnu.org>
2021-11-20 13:26 ` Stefan Monnier [this message]
2021-11-21 8:23 ` master 4351722: Make shr render text with superscripts prettier Lars Ingebrigtsen
2021-11-21 14:24 ` Stefan Monnier
2021-11-21 19:27 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy25jyn4y.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).