* Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package [not found] ` <20220103031922.F1787C0DA19@vcs2.savannah.gnu.org> @ 2022-01-03 10:51 ` Philip Kaludercic 2022-01-03 12:54 ` Eli Zaretskii ` (2 more replies) 0 siblings, 3 replies; 10+ messages in thread From: Philip Kaludercic @ 2022-01-03 10:51 UTC (permalink / raw) To: emacs-devel; +Cc: Stefan Kangas Why was the package added to NonGNU ELPA? We were coordinating to add the package to GNU ELPA: https://github.com/joostkremers/visual-fill-column/issues/52 Stefan Kangas <stefankangas@gmail.com> writes: > branch: main > commit 791bf67d0a5adc4e7b0ea14849e73a399c0a616d > Author: Stefan Kangas <stefan@marxist.se> > Commit: Stefan Kangas <stefan@marxist.se> > > * elpa-packages (visual-fill-column): New package > --- > elpa-packages | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/elpa-packages b/elpa-packages > index dd464ea28f..126195dd0c 100644 > --- a/elpa-packages > +++ b/elpa-packages > @@ -336,6 +336,11 @@ > > ("vc-fossil" :url "https://github.com/venks1/emacs-fossil") > > + ("visual-fill-column" :url "https://codeberg.org/joostkremers/visual-fill-column.git" > + :readme "README.md" > + :ignored-files ("Cask" "LICENSE" "adaptive-wrap.png" "after.png" "before.png" > + "centered.png" "no-adaptive-wrap.png" "test" )) > + > ("web-mode" :url "https://github.com/fxbois/web-mode" > :ignored-files ("issues" "tests" "run.sh")) > > > -- Philip Kaludercic ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package 2022-01-03 10:51 ` [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package Philip Kaludercic @ 2022-01-03 12:54 ` Eli Zaretskii 2022-01-03 13:53 ` Kévin Le Gouguec 2022-01-03 15:54 ` Stefan Monnier 2022-01-03 16:33 ` Stefan Kangas 2 siblings, 1 reply; 10+ messages in thread From: Eli Zaretskii @ 2022-01-03 12:54 UTC (permalink / raw) To: Philip Kaludercic; +Cc: stefan, emacs-devel > From: Philip Kaludercic <philipk@posteo.net> > Date: Mon, 03 Jan 2022 10:51:03 +0000 > Cc: Stefan Kangas <stefan@marxist.se> > > > Why was the package added to NonGNU ELPA? We were coordinating to add > the package to GNU ELPA: > > https://github.com/joostkremers/visual-fill-column/issues/52 Why do we need this on any ELPA, when we have a built-in feature for the same functionality? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package 2022-01-03 12:54 ` Eli Zaretskii @ 2022-01-03 13:53 ` Kévin Le Gouguec 2022-01-03 14:34 ` Eli Zaretskii 0 siblings, 1 reply; 10+ messages in thread From: Kévin Le Gouguec @ 2022-01-03 13:53 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Philip Kaludercic, stefan, emacs-devel Eli Zaretskii <eliz@gnu.org> writes: >> From: Philip Kaludercic <philipk@posteo.net> >> Date: Mon, 03 Jan 2022 10:51:03 +0000 >> Cc: Stefan Kangas <stefan@marxist.se> >> >> >> Why was the package added to NonGNU ELPA? We were coordinating to add >> the package to GNU ELPA: >> >> https://github.com/joostkremers/visual-fill-column/issues/52 > > Why do we need this on any ELPA, when we have a built-in feature for > the same functionality? IIUC from <m1bl3baof0.fsf@yahoo.es>, Emacs does not have this feature yet? In which case, until it is implemented in the display engine, having it in ELPA would make sense? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package 2022-01-03 13:53 ` Kévin Le Gouguec @ 2022-01-03 14:34 ` Eli Zaretskii 2022-01-03 16:33 ` Stefan Kangas 0 siblings, 1 reply; 10+ messages in thread From: Eli Zaretskii @ 2022-01-03 14:34 UTC (permalink / raw) To: Kévin Le Gouguec; +Cc: philipk, stefan, emacs-devel > From: Kévin Le Gouguec <kevin.legouguec@gmail.com> > Cc: Philip Kaludercic <philipk@posteo.net>, stefan@marxist.se, > emacs-devel@gnu.org > Date: Mon, 03 Jan 2022 14:53:12 +0100 > > Eli Zaretskii <eliz@gnu.org> writes: > > >> From: Philip Kaludercic <philipk@posteo.net> > >> Date: Mon, 03 Jan 2022 10:51:03 +0000 > >> Cc: Stefan Kangas <stefan@marxist.se> > >> > >> > >> Why was the package added to NonGNU ELPA? We were coordinating to add > >> the package to GNU ELPA: > >> > >> https://github.com/joostkremers/visual-fill-column/issues/52 > > > > Why do we need this on any ELPA, when we have a built-in feature for > > the same functionality? > > IIUC from <m1bl3baof0.fsf@yahoo.es>, Emacs does not have this feature > yet? In which case, until it is implemented in the display engine, > having it in ELPA would make sense? Sorry, I confused this with visual-column-indicator. But I do think we should implement this in the display engine rather than in Lisp. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package 2022-01-03 14:34 ` Eli Zaretskii @ 2022-01-03 16:33 ` Stefan Kangas 2022-01-03 16:56 ` Eli Zaretskii 0 siblings, 1 reply; 10+ messages in thread From: Stefan Kangas @ 2022-01-03 16:33 UTC (permalink / raw) To: Eli Zaretskii, Kévin Le Gouguec; +Cc: philipk, emacs-devel Eli Zaretskii <eliz@gnu.org> writes: > But I do think we should implement this in the display engine rather > than in Lisp. I agree. Do we have a bug report for something like that, or should I open one? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package 2022-01-03 16:33 ` Stefan Kangas @ 2022-01-03 16:56 ` Eli Zaretskii 0 siblings, 0 replies; 10+ messages in thread From: Eli Zaretskii @ 2022-01-03 16:56 UTC (permalink / raw) To: Stefan Kangas; +Cc: philipk, emacs-devel, kevin.legouguec > From: Stefan Kangas <stefan@marxist.se> > Date: Mon, 3 Jan 2022 11:33:03 -0500 > Cc: philipk@posteo.net, emacs-devel@gnu.org > > Eli Zaretskii <eliz@gnu.org> writes: > > > But I do think we should implement this in the display engine rather > > than in Lisp. > > I agree. > > Do we have a bug report for something like that, or should I open one? I don't think we have such a bug report, so opening one would be appreciated, thanks. I also invite people to work on this, if someone wants to cut their teeth on the display code. The job should be relatively simple, and I can help with orientation. My initial idea would be to make this related to display-fill-column-indicator-mode, in the sense that the text will wrap where the indicator shows it should. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package 2022-01-03 10:51 ` [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package Philip Kaludercic 2022-01-03 12:54 ` Eli Zaretskii @ 2022-01-03 15:54 ` Stefan Monnier 2022-01-03 16:33 ` Stefan Kangas 2 siblings, 0 replies; 10+ messages in thread From: Stefan Monnier @ 2022-01-03 15:54 UTC (permalink / raw) To: Philip Kaludercic; +Cc: emacs-devel, Stefan Kangas Philip Kaludercic [2022-01-03 10:51:03] wrote: > Why was the package added to NonGNU ELPA? We were coordinating to add > the package to GNU ELPA: I'll let you guys figure out what to do, but in case we move it to GNU ELPA, let me know since I it'll require some manual work on elpa.gnu.org. Stefan ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package 2022-01-03 10:51 ` [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package Philip Kaludercic 2022-01-03 12:54 ` Eli Zaretskii 2022-01-03 15:54 ` Stefan Monnier @ 2022-01-03 16:33 ` Stefan Kangas 2022-01-03 17:35 ` Philip Kaludercic 2 siblings, 1 reply; 10+ messages in thread From: Stefan Kangas @ 2022-01-03 16:33 UTC (permalink / raw) To: Philip Kaludercic, emacs-devel Philip Kaludercic <philipk@posteo.net> writes: > Why was the package added to NonGNU ELPA? We were coordinating to add > the package to GNU ELPA: > > https://github.com/joostkremers/visual-fill-column/issues/52 Oops, that's my bad. I didn't think to check the open issues, as they are rarely useful. I'll make it a habit to do that. What do we prefer to do now? I'm more than happy to remove the package, of course. The alternative is to just keep it there until it is ready for GNU ELPA, and users will seamlessly upgrade to the new archive. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package 2022-01-03 16:33 ` Stefan Kangas @ 2022-01-03 17:35 ` Philip Kaludercic 2022-01-03 17:59 ` Stefan Kangas 0 siblings, 1 reply; 10+ messages in thread From: Philip Kaludercic @ 2022-01-03 17:35 UTC (permalink / raw) To: Stefan Kangas; +Cc: emacs-devel Stefan Kangas <stefan@marxist.se> writes: > Philip Kaludercic <philipk@posteo.net> writes: > >> Why was the package added to NonGNU ELPA? We were coordinating to add >> the package to GNU ELPA: >> >> https://github.com/joostkremers/visual-fill-column/issues/52 > > Oops, that's my bad. I didn't think to check the open issues, as they > are rarely useful. I'll make it a habit to do that. > > What do we prefer to do now? I'm more than happy to remove the package, > of course. The alternative is to just keep it there until it is ready > for GNU ELPA, and users will seamlessly upgrade to the new archive. From my understanding GNU ELPA is preferred, and especially with packages like there where there are just a few significant contributors, I think checking if the copyright assignments can be collected (or have already been signed) is worth the effort. -- Philip Kaludercic ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package 2022-01-03 17:35 ` Philip Kaludercic @ 2022-01-03 17:59 ` Stefan Kangas 0 siblings, 0 replies; 10+ messages in thread From: Stefan Kangas @ 2022-01-03 17:59 UTC (permalink / raw) To: Philip Kaludercic; +Cc: emacs-devel Philip Kaludercic <philipk@posteo.net> writes: > From my understanding GNU ELPA is preferred, and especially with > packages like there where there are just a few significant contributors, > I think checking if the copyright assignments can be collected (or have > already been signed) is worth the effort. I agree, but the question is what to do now about the NonGNU ELPA package that was added. Should it be deleted from that archive, or are we fine with keeping it there until we are ready to add it to GNU ELPA? ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-01-03 17:59 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <164117996273.7430.4856914456706939523@vcs2.savannah.gnu.org>
[not found] ` <20220103031922.F1787C0DA19@vcs2.savannah.gnu.org>
2022-01-03 10:51 ` [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package Philip Kaludercic
2022-01-03 12:54 ` Eli Zaretskii
2022-01-03 13:53 ` Kévin Le Gouguec
2022-01-03 14:34 ` Eli Zaretskii
2022-01-03 16:33 ` Stefan Kangas
2022-01-03 16:56 ` Eli Zaretskii
2022-01-03 15:54 ` Stefan Monnier
2022-01-03 16:33 ` Stefan Kangas
2022-01-03 17:35 ` Philip Kaludercic
2022-01-03 17:59 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).