From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 60dd962507: Translate more keys on Haiku
Date: Wed, 12 Jan 2022 10:38:42 -0500 [thread overview]
Message-ID: <jwvy23lvucq.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20220112072356.E3CC9C0DA2E@vcs2.savannah.gnu.org> (Po Lu via Mailing list for Emacs changes's message of "Wed, 12 Jan 2022 02:23:56 -0500 (EST)")
> @@ -186,6 +186,14 @@ keysym_from_raw_char (int32 raw, int32 key, unsigned *code)
>
> case B_FUNCTION_KEY:
> *code = XK_F1 + key - 2;
> +
> + if (*code - XK_F1 == 12)
> + *code = XK_Print;
> + else if (*code - XK_F1 == 13)
> + *code = XK_Scroll_Lock;
> + else if (*code - XK_F1 == 14)
> + *code = XK_Pause;
Could you add a comment explaining why these specific key codes are
mapped to these specific keys? Maybe a reference to some doc defining
F13 as print, F14 as scrolllock, and F15 as pause, or something
like that?
Stefan
next parent reply other threads:[~2022-01-12 15:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <164197223649.17592.3617443770011266372@vcs2.savannah.gnu.org>
[not found] ` <20220112072356.E3CC9C0DA2E@vcs2.savannah.gnu.org>
2022-01-12 15:38 ` Stefan Monnier [this message]
2022-01-13 0:38 ` master 60dd962507: Translate more keys on Haiku Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy23lvucq.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).