From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/git-commit 8b5d0b2bc6 1/2: =?utf-8?Q?Don?= =?utf-8?Q?=E2=80=99t?= try to evaluate startup assertions when byte-compiling Date: Fri, 18 Mar 2022 15:33:56 -0400 Message-ID: References: <164762268794.12821.8588776573613488178@vcs2.savannah.gnu.org> <20220318165808.45C11C01681@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1892"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Philipp Stephani To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 18 20:35:02 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVINI-0000G5-Hj for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Mar 2022 20:35:00 +0100 Original-Received: from localhost ([::1]:48556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVINH-0004ng-3s for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Mar 2022 15:34:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVIMO-0003PW-9j for emacs-devel@gnu.org; Fri, 18 Mar 2022 15:34:04 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVIML-0004Hb-Ci for emacs-devel@gnu.org; Fri, 18 Mar 2022 15:34:03 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2DC7B4422CB; Fri, 18 Mar 2022 15:33:59 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 90A3C4422CE; Fri, 18 Mar 2022 15:33:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1647632037; bh=eTdEiseav6ynveJxH5yZq6BFBDoK8P+0ZD19Ge81pFg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=K/QajD7wfztGZFl3jfnWywXhq/tbJEUzEBrK52YHmlJosVKloTOWKIb1pbPy7B3Bl jMcPzs0rx2cHg6OoxRv1jMcVjyQVl0oSC8uXYYXF5NtpYrhNN9otwJxPrIz4x7G+fb RdIZNyweN0BXybF9edM92W9BTzYXN5uKTzhFzDnKOtQytW3+Xx0CLmXtoXs/sMsCEe gwUVYGfZpSp08dZYcpSER8qdDv4e6mrJA4/4epMBpMwxwAxGKpu/7HacZ2xH+wI5MF k6mSMYaFhbMV9uw7+jFtwGIXjVHx4GKbp3TZqtBdYlBSoJJzlrQgP3pv6PoVJwPtlx LXYekqMyPL4+g== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 690E2120234; Fri, 18 Mar 2022 15:33:57 -0400 (EDT) In-Reply-To: <20220318165808.45C11C01681@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Fri, 18 Mar 2022 12:58:08 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287298 Archived-At: > --- a/lisp/magit.el > +++ b/lisp/magit.el > @@ -616,7 +616,7 @@ and Emacs to it." > ;; See comment above. > "https://github.com/magit/magit/wiki/Don't-set-$GIT_DIR-and-alike")) > ;; Git isn't required while building Magit. > - (cl-eval-when (load eval) > + (unless byte-compile-current-file > (magit-git-version-assert)) > (when (version< emacs-version magit--minimal-emacs) > (display-warning 'magit (format "\ > @@ -672,10 +672,11 @@ For X11 something like ~/.xinitrc should work.\n" > (with-eval-after-load 'bookmark > (require 'magit-bookmark)) > > -(if after-init-time > - (progn (magit-startup-asserts) > - (magit-version)) > - (add-hook 'after-init-hook #'magit-startup-asserts t) > - (add-hook 'after-init-hook #'magit-version t)) > +(unless byte-compile-current-file > + (if after-init-time > + (progn (magit-startup-asserts) > + (magit-version)) > + (add-hook 'after-init-hook #'magit-startup-asserts t) > + (add-hook 'after-init-hook #'magit-version t))) > > ;;; magit.el ends here BTW, the better way to do that is to move the checking code to a function and call that function the first time Magit is used, rather than run it when loading some file. Stefan "loading a file should not have such side-effects"