From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [External] : [emacs bookmark.el] Sorting by last set Date: Wed, 01 Jun 2022 08:08:32 -0400 Message-ID: References: <877d6b88pz.fsf@elite.giraud> <875ylv6j58.fsf@elite.giraud> <87o7zngcgf.fsf@gnus.org> <87k0a93g4z.fsf@elite.giraud> <87y1yp1vnw.fsf@elite.giraud> <877d69lyt2.fsf@red-bean.com> <87ilpsd0hv.fsf@gnus.org> <87tu9c1c0k.fsf@elite.giraud> <87leuo12fh.fsf@elite.giraud> <87zgj38ds1.fsf@gnus.org> <875ylr15nm.fsf@elite.giraud> <8735gv6rim.fsf@gnus.org> <871qwf14ef.fsf@elite.giraud> <878rqm54kc.fsf@gnus.org> <87czfvjcbx.fsf@elite.giraud> <878rqh5z2v.fsf@gnus.org> <864k147vx6.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6580"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Manuel Giraud , Karl Fogel , Drew Adams , emacs-devel To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 01 14:10:01 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nwNAn-0001Sv-Bo for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Jun 2022 14:10:01 +0200 Original-Received: from localhost ([::1]:49810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwNAl-0000Dc-V9 for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Jun 2022 08:10:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwN9S-0007PP-Jd for emacs-devel@gnu.org; Wed, 01 Jun 2022 08:08:38 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:50615) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwN9P-0001iZ-V2 for emacs-devel@gnu.org; Wed, 01 Jun 2022 08:08:37 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 12C30807CB; Wed, 1 Jun 2022 08:08:35 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8EC4480009; Wed, 1 Jun 2022 08:08:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1654085313; bh=KqQP88ER9KCWZZ39Kf3TWvFxYWsfJoUlD2/NEFlbt8M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=LYh8EkWmMe0Uh2hCjIbuRvfCUdZRbSUCJAZCNEn9Dq178cbxkFVxI/ts9rPOE9Thc mLmcj/T8Z37hZYiuJFP5tU7Z6413SMy6sezcpfO9o6G5CD4X9U1WeEzx0+UUBbbtDY vexNJN1f9DOjR+MJUfsQIwAiumxoprK0hn4hPlQJIOIwRz0iZV1LK6OtyDX9tdTg/u 2+CYuMh/eUY1dxbRyVVpT9B46W7hnofvwyWExXz4QiVwMmb9bxsdZtBh9ZLYy4LLyt pT5kUPM23CoZ67zKRTIHCUc3deHLjmm7JoqQMM/engaxMZb4GTAiaR8RKItbSzDRwZ ppQatqtsrWCmA== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 535F712036E; Wed, 1 Jun 2022 08:08:33 -0400 (EDT) In-Reply-To: <864k147vx6.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 01 Jun 2022 09:16:57 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290487 Archived-At: >>> You were right, it feels more correct to fix the tests then to handle >>> last-modified separately. >> Thanks; pushed to Emacs 29 (with some whitespace and naming changes to >> make it fit our conventions). > I tried it out, but noticed that it writes unintelligible numbers > in the bookmarks file, such as (last-modified 25239 1033 644055 97000). AFAIK the bookmarks format is not designed to be consumed by a human, so it's not a bad choice. > Wouldn't it be more user-friendly to write timestamps in a more > recognizable format? E.g. with ISO date: (last-modified "20220601"). That would make it slower to compare when sorting, so I think the current choice of using an Emacs time object is fine. Stefan