From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master fcade74066d 1/2: src/comp.c: Use `pending_funcalls` to fix bug#64494 Date: Thu, 13 Jul 2023 22:31:03 -0400 Message-ID: References: <168929813505.29645.9269723900058607721@vcs2.savannah.gnu.org> <20230714012855.85A9EC06C70@vcs2.savannah.gnu.org> <87a5vz9soj.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1385"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, Andrea Corallo To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 14 04:32:06 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qK8bF-00008S-Mm for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jul 2023 04:32:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qK8aM-0002qx-5P; Thu, 13 Jul 2023 22:31:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK8aL-0002qp-Bp for emacs-devel@gnu.org; Thu, 13 Jul 2023 22:31:09 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK8aJ-0001pc-N3; Thu, 13 Jul 2023 22:31:09 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E661D442795; Thu, 13 Jul 2023 22:31:05 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9E459442801; Thu, 13 Jul 2023 22:31:04 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689301864; bh=K5QU0D++chMHNsPqViDoXEuXOkhv7yLa4Sd8Qfd5lVw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=PrnL1vxWO72/a4Bad8ZZb3Bl8rsKuryCLfABQX8b6a2CCs9yvwEKMZMquqQp8f9VI W4PAAGxyO29RegW3kyKsIv158BDUmjjieyM3+VT0Ea1HuBXPe2hIcz0OPHiIXTC5fc 4XyCzTWmamkWCkxK+pef3NRYsbPfqL13Y1PcT2Vyyfri6M69o6CX4wPeVCRGTaJRn+ zCCPvR6/u349HHD5mhTWkWSk1HcKyTKJb2LjdGnIVuNbu//RIQTRfH0TFMXTBf4xls 1FdtFPpCMHsLwNWB8W9RKepDMctfnDsoawZPIouRssMwYEFHoDsLS4babOuVtka0d3 YtqStov757vCQ== Original-Received: from pastel (unknown [104.247.239.133]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 76ACF1201B8; Thu, 13 Jul 2023 22:31:04 -0400 (EDT) In-Reply-To: <87a5vz9soj.fsf@yahoo.com> (Po Lu's message of "Fri, 14 Jul 2023 09:40:28 +0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307844 Archived-At: >> + DEFSYM (Qnative__compile_async, "native--compile-async"); > Minor nit: shouldn't this be named `comp--compile-async' or > `native-comp--compile-async'? [ Side note: I did not choose this name, I only replaced `intern ("native--compile-async")` with this DEFSYM. ] It does seem inconsistent, indeed. `comp--compile-async' would be my choice. Stefan