unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org, Andrea Corallo <acorallo@gnu.org>
Subject: Re: master fcade74066d 1/2: src/comp.c: Use `pending_funcalls` to fix bug#64494
Date: Thu, 13 Jul 2023 22:31:03 -0400	[thread overview]
Message-ID: <jwvy1jjfcr7.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87a5vz9soj.fsf@yahoo.com> (Po Lu's message of "Fri, 14 Jul 2023 09:40:28 +0800")

>> +  DEFSYM (Qnative__compile_async, "native--compile-async");
> Minor nit: shouldn't this be named `comp--compile-async' or
> `native-comp--compile-async'?

[ Side note: I did not choose this name, I only replaced `intern
  ("native--compile-async")` with this DEFSYM.  ]

It does seem inconsistent, indeed.
`comp--compile-async' would be my choice.


        Stefan




      reply	other threads:[~2023-07-14  2:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <168929813505.29645.9269723900058607721@vcs2.savannah.gnu.org>
     [not found] ` <20230714012855.85A9EC06C70@vcs2.savannah.gnu.org>
2023-07-14  1:40   ` master fcade74066d 1/2: src/comp.c: Use `pending_funcalls` to fix bug#64494 Po Lu
2023-07-14  2:31     ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvy1jjfcr7.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=acorallo@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).