Re: [nongnu] elpa/beancount b01c8c59c9 2/3: Merge branch 'main' into more-xref

Re: [nongnu] elpa/beancount b01c8c59c9 2/3: Merge branch 'main' into more-xref

[Stefan Monnier]

[ Salut Martin! ]

> -  "Directive names that can appear after a date and are _not_ followed by an account.")
> +  "Directive names that can appear after a date and are _not_ followed by an
> +account.")

[ Ideally the first line should "stand on its own".  I remember looking at
  this one and wondering how to do that.  I never bothered to send the
  corresponding patch, but I used:

      "Directives with a date but without an account.
    List of directive names that can appear after a date and that are
    _not_ followed by an account.")

]

> +(defun beancount-linked--get-target-under-point ()
> +  "Get link, tag or line no under point, or nil."

[ Not sure what you meant by "no under point".  ]

>  (defun beancount--fava-filter (process output)
>    "Open fava url as soon as the address is announced."
> +  (ignore process)
>    (if-let ((url (string-match "Running Fava on \\(http://.+:[0-9]+\\)\n" output)))
>        (browse-url (match-string 1 output))))

The officially sanctioned way to say that `process` is not used is with
an underscore:

    (defun beancount--fava-filter (_process output)

Offenders will be prosecuted to the full extent of the law.


        Stefan

Re: [nongnu] elpa/beancount b01c8c59c9 2/3: Merge branch 'main' into more-xref

[Martin Blais]

[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]

Thank you thank you
https://github.com/beancount/beancount-mode/commit/152020dc5cfc2dfb691f92a350dd689af487a00a


On Sun, Jun 23, 2024 at 10:32 PM Stefan Monnier <monnier@iro.umontreal.ca>
wrote:

> [ Salut Martin! ]
>
> > -  "Directive names that can appear after a date and are _not_ followed
> by an account.")
> > +  "Directive names that can appear after a date and are _not_ followed
> by an
> > +account.")
>
> [ Ideally the first line should "stand on its own".  I remember looking at
>   this one and wondering how to do that.  I never bothered to send the
>   corresponding patch, but I used:
>
>       "Directives with a date but without an account.
>     List of directive names that can appear after a date and that are
>     _not_ followed by an account.")
>
> ]
>
> > +(defun beancount-linked--get-target-under-point ()
> > +  "Get link, tag or line no under point, or nil."
>
> [ Not sure what you meant by "no under point".  ]
>
> >  (defun beancount--fava-filter (process output)
> >    "Open fava url as soon as the address is announced."
> > +  (ignore process)
> >    (if-let ((url (string-match "Running Fava on \\(http://.+:[0-9]+\\)\n"
> output)))
> >        (browse-url (match-string 1 output))))
>
> The officially sanctioned way to say that `process` is not used is with
> an underscore:
>
>     (defun beancount--fava-filter (_process output)
>
> Offenders will be prosecuted to the full extent of the law.
>
>
>         Stefan
>
>

[-- Attachment #2: Type: text/html, Size: 2373 bytes --]