From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Martin Blais <blais@furius.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [nongnu] elpa/beancount b01c8c59c9 2/3: Merge branch 'main' into more-xref
Date: Sun, 23 Jun 2024 22:32:20 -0400 [thread overview]
Message-ID: <jwvy16v2i6e.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20240624015950.339C8C1FB73@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Sun, 23 Jun 2024 21:59:50 -0400 (EDT)")
[ Salut Martin! ]
> - "Directive names that can appear after a date and are _not_ followed by an account.")
> + "Directive names that can appear after a date and are _not_ followed by an
> +account.")
[ Ideally the first line should "stand on its own". I remember looking at
this one and wondering how to do that. I never bothered to send the
corresponding patch, but I used:
"Directives with a date but without an account.
List of directive names that can appear after a date and that are
_not_ followed by an account.")
]
> +(defun beancount-linked--get-target-under-point ()
> + "Get link, tag or line no under point, or nil."
[ Not sure what you meant by "no under point". ]
> (defun beancount--fava-filter (process output)
> "Open fava url as soon as the address is announced."
> + (ignore process)
> (if-let ((url (string-match "Running Fava on \\(http://.+:[0-9]+\\)\n" output)))
> (browse-url (match-string 1 output))))
The officially sanctioned way to say that `process` is not used is with
an underscore:
(defun beancount--fava-filter (_process output)
Offenders will be prosecuted to the full extent of the law.
Stefan
next parent reply other threads:[~2024-06-24 2:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171919438737.27087.1789715175734348442@vcs2.savannah.gnu.org>
[not found] ` <20240624015950.339C8C1FB73@vcs2.savannah.gnu.org>
2024-06-24 2:32 ` Stefan Monnier [this message]
2024-06-24 3:08 ` [nongnu] elpa/beancount b01c8c59c9 2/3: Merge branch 'main' into more-xref Martin Blais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy16v2i6e.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=blais@furius.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).