From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: lexical-binding in paredit Date: Sun, 03 Nov 2024 20:54:36 -0500 Message-ID: References: <20241103214444.39A5A60A70@jupiter.mumble.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2369"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Kangas , Sean Whitton , Jim Porter , Visuwesh , emacs-devel@gnu.org To: Taylor R Campbell Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 04 02:55:56 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t7mJv-0000SL-G4 for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Nov 2024 02:55:55 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t7mIz-0005HE-EM; Sun, 03 Nov 2024 20:54:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7mIw-0005Gx-0y for emacs-devel@gnu.org; Sun, 03 Nov 2024 20:54:54 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7mIu-0003YI-4y for emacs-devel@gnu.org; Sun, 03 Nov 2024 20:54:53 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BBB2880152; Sun, 3 Nov 2024 20:54:46 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1730685285; bh=zGb2N/yY1FZSsbFibo5VKmd8tTzVULmYFnAEkUM+yeo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=jHS3HDN65g+k4WUsmPneApVTVqOa8ThLx+69LcT/XptJU5dR9vG2giHPHing7oyOu bPEs9SE47RmyUhfEBkneAg2TmuIl5UiUbvoST+vn2EcNWDa/y46042IcAchjfnpUkH 60KV/LY6ih4KpqQLIhh1Jwb2yP2gPsXCBACrubfH30+K+rFDyhwfcpzQY4OvbcHsq1 7V4L3NTEYqptxkiMqwpwrdnrAfAkkY3z+InfXymT+JBO9aFBI5dvwNqe/3CVSooCed 81AxjVSqDzA5urPxbOo+A0/27uCYDkBcVHRcJE8HLPw95c/sRKdZ42bCIKT6YbuO1s HLU5YXiNOL1vA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B02BE80966; Sun, 3 Nov 2024 20:54:45 -0500 (EST) Original-Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6A02E1203CD; Sun, 3 Nov 2024 20:54:45 -0500 (EST) In-Reply-To: <20241103214444.39A5A60A70@jupiter.mumble.net> (Taylor R. Campbell's message of "Sun, 3 Nov 2024 21:44:43 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325073 Archived-At: > Since paredit.el still works fine in GNU Emacs 21, I don't see the > need for the large amount of churn to drop support for it, but maybe I The only part of the patch related to support for older Emacsen was the part described as: (paredit-initialize-comment-dwim): Delete function needed only for Emacs-21. (paredit-comment-dwim): Call `comment-normalize-vars` instead. > missed some other important fix in the churn. Nothing important, no: Add `declare`s to `defmacro`s. would help Edebugging, but I guess that hasn't been a problem so far. Avoid obsolete `point-at-eol/bol`. silences compiler warnings but apparently not in the version of Emacs you're using. (paredit-xemacs-p, paredit-gnu-emacs-p): Inline all calls (so the byte-compiler can throw away the irrelevant code) and then delete. (xcond): Delete macro, since after expanding `paredit-*emacs-p` it's makes the source code simpler and the .elc code shorter. Stefan