* Should xemacs feature test be removed from url package?
@ 2005-09-25 17:54 CHENG Gao
2005-09-26 4:49 ` Richard M. Stallman
2005-09-26 13:14 ` Stefan Monnier
0 siblings, 2 replies; 13+ messages in thread
From: CHENG Gao @ 2005-09-25 17:54 UTC (permalink / raw)
Because url package was merged into Emacs long time ago, my
understanding is it's meaningless to do xemacs feature test in url
codes. So should these test codes be removed?
1. utl-http.el line 830-832:
,----
| 'face (if (featurep 'xemacs)
| 'text-cursor
| 'cursor)
`----
may change to
,----
| 'face 'cursor
`----
2. url-dired.el line 32-34:
,----
| (if (featurep 'xemacs)
| (define-key map [button2] 'url-dired-find-file-mouse)
| (define-key map [mouse-2] 'url-dired-find-file-mouse))
`----
may change to
,----
| (define-key map [mouse-2] 'url-dired-find-file-mouse)
`----
3. url-file.el line 233-238:
,----
| (if (featurep 'xemacs)
| (progn
| (url-file-create-wrapper directory-files (url &optional full match nosort files-only))
| (url-file-create-wrapper file-truename (url &optional default)))
| (url-file-create-wrapper directory-files (url &optional full match nosort))
| (url-file-create-wrapper file-truename (url &optional counter prev-dirs)))
`----
may change to
,----
| (url-file-create-wrapper directory-files (url &optional full match nosort))
| (url-file-create-wrapper file-truename (url &optional counter prev-dirs))
`----
4. url-handlers.el line 250-261.el:
,----
| (if (featurep 'xemacs)
| (progn
| ;; XEmacs specific prototypes
| (url-handlers-create-wrapper
| directory-files (url &optional full match nosort files-only))
| (url-handlers-create-wrapper
| file-truename (url &optional default)))
| ;; Emacs specific prototypes
| (url-handlers-create-wrapper
| directory-files (url &optional full match nosort))
| (url-handlers-create-wrapper
| file-truename (url &optional counter prev-dirs)))
`----
may change to
,----
| (url-handlers-create-wrapper
| directory-files (url &optional full match nosort))
| (url-handlers-create-wrapper
| file-truename (url &optional counter prev-dirs))
`----
5. url-nfs.el line 90-95:
,----
| (if (featurep 'xemacs)
| (progn
| (url-nfs-create-wrapper directory-files (url &optional full match nosort files-only))
| (url-nfs-create-wrapper file-truename (url &optional default)))
| (url-nfs-create-wrapper directory-files (url &optional full match nosort))
| (url-nfs-create-wrapper file-truename (url &optional counter prev-dirs)))
`----
may change to
,----
| (url-nfs-create-wrapper directory-files (url &optional full match nosort))
| (url-nfs-create-wrapper file-truename (url &optional counter prev-dirs))
`----
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Should xemacs feature test be removed from url package?
2005-09-25 17:54 Should xemacs feature test be removed from url package? CHENG Gao
@ 2005-09-26 4:49 ` Richard M. Stallman
2005-09-26 5:04 ` Cheng Gao
2005-09-26 13:14 ` Stefan Monnier
1 sibling, 1 reply; 13+ messages in thread
From: Richard M. Stallman @ 2005-09-26 4:49 UTC (permalink / raw)
Cc: emacs-devel
Are the developers of the URL package still maintaining it separately?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Should xemacs feature test be removed from url package?
2005-09-26 4:49 ` Richard M. Stallman
@ 2005-09-26 5:04 ` Cheng Gao
2005-09-26 5:14 ` David Kastrup
2005-09-26 23:55 ` Richard M. Stallman
0 siblings, 2 replies; 13+ messages in thread
From: Cheng Gao @ 2005-09-26 5:04 UTC (permalink / raw)
>>>>> "Richard" == Richard M Stallman <rms@gnu.org> writes:
Richard> Are the developers of the URL package still maintaining it
Richard> separately?
Seems not.
Old home of URL package: http://www.gnu.org/software/url/
It informed move to Savannah.
New home: http://savannah.gnu.org/projects/url/
And project admin Fave Love (fx) said:
,----
| URL is now in Emacs
| posted by fx, Sat 10/16/04 at 18:29 - 0 replies
|
| URL is now being maintained in the Emacs CVS repository, so this
| project is probably obsolete.
`----
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Should xemacs feature test be removed from url package?
2005-09-26 5:04 ` Cheng Gao
@ 2005-09-26 5:14 ` David Kastrup
2005-09-26 23:55 ` Richard M. Stallman
2005-09-26 23:55 ` Richard M. Stallman
1 sibling, 1 reply; 13+ messages in thread
From: David Kastrup @ 2005-09-26 5:14 UTC (permalink / raw)
Cc: emacs-devel
Cheng Gao <chenggao@gmail.com> writes:
>>>>>> "Richard" == Richard M Stallman <rms@gnu.org> writes:
>
> Richard> Are the developers of the URL package still maintaining it
> Richard> separately?
>
> Seems not.
>
> Old home of URL package: http://www.gnu.org/software/url/
> It informed move to Savannah.
>
> New home: http://savannah.gnu.org/projects/url/
>
> And project admin Fave Love (fx) said:
>
> ,----
> | URL is now in Emacs
> | posted by fx, Sat 10/16/04 at 18:29 - 0 replies
> |
> | URL is now being maintained in the Emacs CVS repository, so this
> | project is probably obsolete.
>
> `----
Well, I think then it should be left to the package maintainer to
decide whether he wants to maintain a common XEmacs/Emacs version, or
just maintain the version for Emacs.
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Should xemacs feature test be removed from url package?
2005-09-26 5:14 ` David Kastrup
@ 2005-09-26 23:55 ` Richard M. Stallman
0 siblings, 0 replies; 13+ messages in thread
From: Richard M. Stallman @ 2005-09-26 23:55 UTC (permalink / raw)
Cc: emacs-devel, chenggao
Well, I think then it should be left to the package maintainer to
decide whether he wants to maintain a common XEmacs/Emacs version, or
just maintain the version for Emacs.
The author is Bill Perry, but ISTR he is not in contact with us
any more. When is the last time we heard from him?
If he is indeed still involved, then we can ask him what he prefers.
If not, we should put "Maintainer: FSF" in these files.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Should xemacs feature test be removed from url package?
2005-09-26 5:04 ` Cheng Gao
2005-09-26 5:14 ` David Kastrup
@ 2005-09-26 23:55 ` Richard M. Stallman
2005-09-27 3:16 ` Cheng Gao
1 sibling, 1 reply; 13+ messages in thread
From: Richard M. Stallman @ 2005-09-26 23:55 UTC (permalink / raw)
Cc: emacs-devel
Richard> Are the developers of the URL package still maintaining it
Richard> separately?
Seems not.
If that is the case, the only reason to maintain XEmacs conditionals
in URL is if XEmacs developers want to cooperate with us on
maintaining that code.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Should xemacs feature test be removed from url package?
2005-09-26 23:55 ` Richard M. Stallman
@ 2005-09-27 3:16 ` Cheng Gao
2005-09-27 6:42 ` David Kastrup
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Cheng Gao @ 2005-09-27 3:16 UTC (permalink / raw)
*On Mon, 26 Sep 2005 19:55:16 -0400
* "Richard M. Stallman" <rms@gnu.org> climbed out of the dark hell and cried out:
> Richard> Are the developers of the URL package still maintaining it
> Richard> separately?
>
> Seems not.
>
> If that is the case, the only reason to maintain XEmacs conditionals
> in URL is if XEmacs developers want to cooperate with us on
> maintaining that code.
Xemacs does not include URL package. It has only W3 package in its
package system, which is last version of W3 (p4.0pre.47).
After moving to Savannah, URL was split from W3 as a separate project.
And then it's included in Emacs CVS. And W3 project in Savannah does not
contain URL files anymore.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Should xemacs feature test be removed from url package?
2005-09-27 3:16 ` Cheng Gao
@ 2005-09-27 6:42 ` David Kastrup
2005-09-27 15:43 ` Stefan Monnier
2005-09-27 21:58 ` Richard M. Stallman
2005-10-10 23:47 ` Richard M. Stallman
2 siblings, 1 reply; 13+ messages in thread
From: David Kastrup @ 2005-09-27 6:42 UTC (permalink / raw)
Cc: emacs-devel
Cheng Gao <chenggao@gmail.com> writes:
> *On Mon, 26 Sep 2005 19:55:16 -0400
> * "Richard M. Stallman" <rms@gnu.org> climbed out of the dark hell and cried out:
>
>> Richard> Are the developers of the URL package still maintaining it
>> Richard> separately?
>>
>> Seems not.
>>
>> If that is the case, the only reason to maintain XEmacs conditionals
>> in URL is if XEmacs developers want to cooperate with us on
>> maintaining that code.
>
> Xemacs does not include URL package. It has only W3 package in its
> package system, which is last version of W3 (p4.0pre.47).
>
> After moving to Savannah, URL was split from W3 as a separate project.
> And then it's included in Emacs CVS. And W3 project in Savannah does not
> contain URL files anymore.
Sounds like a total mess for XEmacs developers any which way. Unless
some XEmacs developer volunteers maintaining for the XEmacs parts, it
is not likely to be much of a help keeping them. How about tagging
the current state with something like url_with_xemacs, then moving
XEmacs support out? In that way, if some XEmacs developer ever
volunteers to take it up at some time, he can just work on remerging
the branches.
I think that seems like a saner approach than letting the support
remain in head with an unknown and rotting state of functionality for
XEmacs.
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Should xemacs feature test be removed from url package?
2005-09-27 6:42 ` David Kastrup
@ 2005-09-27 15:43 ` Stefan Monnier
0 siblings, 0 replies; 13+ messages in thread
From: Stefan Monnier @ 2005-09-27 15:43 UTC (permalink / raw)
Cc: emacs-devel, Cheng Gao
> Sounds like a total mess for XEmacs developers any which way. Unless
> some XEmacs developer volunteers maintaining for the XEmacs parts, it
> is not likely to be much of a help keeping them. How about tagging
> the current state with something like url_with_xemacs, then moving
> XEmacs support out? In that way, if some XEmacs developer ever
> volunteers to take it up at some time, he can just work on remerging
> the branches.
> I think that seems like a saner approach than letting the support
> remain in head with an unknown and rotting state of functionality for
> XEmacs.
I'd rather we don't waste any time trying to remove XEmacs support.
If and when the XEmacs conditionals bother us, we can drop them, but we
shouldn't actively try and remove them for their own sake.
Stefan
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Should xemacs feature test be removed from url package?
2005-09-27 3:16 ` Cheng Gao
2005-09-27 6:42 ` David Kastrup
@ 2005-09-27 21:58 ` Richard M. Stallman
2005-10-10 23:47 ` Richard M. Stallman
2 siblings, 0 replies; 13+ messages in thread
From: Richard M. Stallman @ 2005-09-27 21:58 UTC (permalink / raw)
Cc: emacs-devel
If Bill Perry responds to me, I think it is best to see what he thinks
about the question. If he doesn't respond, let's delete those conditionals.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Should xemacs feature test be removed from url package?
2005-09-27 3:16 ` Cheng Gao
2005-09-27 6:42 ` David Kastrup
2005-09-27 21:58 ` Richard M. Stallman
@ 2005-10-10 23:47 ` Richard M. Stallman
2005-10-13 16:07 ` CHENG Gao
2 siblings, 1 reply; 13+ messages in thread
From: Richard M. Stallman @ 2005-10-10 23:47 UTC (permalink / raw)
Cc: emacs-devel
Bill Perry did not respond. So let's delete those conditionals.
Do you want to do it?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Should xemacs feature test be removed from url package?
2005-10-10 23:47 ` Richard M. Stallman
@ 2005-10-13 16:07 ` CHENG Gao
0 siblings, 0 replies; 13+ messages in thread
From: CHENG Gao @ 2005-10-13 16:07 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 248 bytes --]
*On Mon, 10 Oct 2005 19:47:13 -0400
* "Richard M. Stallman" <rms@gnu.org> climbed out of the dark hell and
* cried out:
> Bill Perry did not respond. So let's delete those conditionals.
> Do you want to do it?
Attached please find unified diff.
[-- Attachment #2: url package diff with xemacs feature test removed --]
[-- Type: application/octet-stream, Size: 3622 bytes --]
--- url-http.el.orig 2005-10-04 19:22:22.000000000 +0800
+++ url-http.el 2005-10-13 23:50:10.000000000 +0800
@@ -840,9 +840,7 @@
(list 'start-open t
'end-open t
'chunked-encoding t
- 'face (if (featurep 'xemacs)
- 'text-cursor
- 'cursor)
+ 'face 'cursor
'invisible t))
(setq url-http-chunked-length (string-to-number (buffer-substring
(match-beginning 1)
--- url-dired.el.orig 2005-08-19 23:52:27.000000000 +0800
+++ url-dired.el 2005-10-13 23:51:45.000000000 +0800
@@ -31,9 +31,7 @@
(defvar url-dired-minor-mode-map
(let ((map (make-sparse-keymap)))
(define-key map "\C-m" 'url-dired-find-file)
- (if (featurep 'xemacs)
- (define-key map [button2] 'url-dired-find-file-mouse)
- (define-key map [mouse-2] 'url-dired-find-file-mouse))
+ (define-key map [mouse-2] 'url-dired-find-file-mouse)
map)
"Keymap used when browsing directories.")
--- url-file.el.orig 2005-08-19 23:52:27.000000000 +0800
+++ url-file.el 2005-10-13 23:53:33.000000000 +0800
@@ -230,12 +230,8 @@
(url-file-create-wrapper file-readable-p (url))
(url-file-create-wrapper file-writable-p (url))
(url-file-create-wrapper file-executable-p (url))
-(if (featurep 'xemacs)
- (progn
- (url-file-create-wrapper directory-files (url &optional full match nosort files-only))
- (url-file-create-wrapper file-truename (url &optional default)))
- (url-file-create-wrapper directory-files (url &optional full match nosort))
- (url-file-create-wrapper file-truename (url &optional counter prev-dirs)))
+(url-file-create-wrapper directory-files (url &optional full match nosort))
+(url-file-create-wrapper file-truename (url &optional counter prev-dirs))
(provide 'url-file)
--- url-handlers.el.orig 2005-08-19 23:52:27.000000000 +0800
+++ url-handlers.el 2005-10-13 23:55:16.000000000 +0800
@@ -246,19 +246,8 @@
(url-handlers-create-wrapper file-writable-p (url))
(url-handlers-create-wrapper file-directory-p (url))
(url-handlers-create-wrapper file-executable-p (url))
-
-(if (featurep 'xemacs)
- (progn
- ;; XEmacs specific prototypes
- (url-handlers-create-wrapper
- directory-files (url &optional full match nosort files-only))
- (url-handlers-create-wrapper
- file-truename (url &optional default)))
- ;; Emacs specific prototypes
- (url-handlers-create-wrapper
- directory-files (url &optional full match nosort))
- (url-handlers-create-wrapper
- file-truename (url &optional counter prev-dirs)))
+(url-handlers-create-wrapper directory-files (url &optional full match nosort))
+(url-handlers-create-wrapper file-truename (url &optional counter prev-dirs))
(add-hook 'find-file-hook 'url-handlers-set-buffer-mode)
--- url-nfs.el.orig 2005-08-19 23:52:28.000000000 +0800
+++ url-nfs.el 2005-10-13 23:56:08.000000000 +0800
@@ -87,12 +87,8 @@
(url-nfs-create-wrapper file-readable-p (url))
(url-nfs-create-wrapper file-writable-p (url))
(url-nfs-create-wrapper file-executable-p (url))
-(if (featurep 'xemacs)
- (progn
- (url-nfs-create-wrapper directory-files (url &optional full match nosort files-only))
- (url-nfs-create-wrapper file-truename (url &optional default)))
- (url-nfs-create-wrapper directory-files (url &optional full match nosort))
- (url-nfs-create-wrapper file-truename (url &optional counter prev-dirs)))
+(url-nfs-create-wrapper directory-files (url &optional full match nosort))
+(url-nfs-create-wrapper file-truename (url &optional counter prev-dirs))
(provide 'url-nfs)
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Should xemacs feature test be removed from url package?
2005-09-25 17:54 Should xemacs feature test be removed from url package? CHENG Gao
2005-09-26 4:49 ` Richard M. Stallman
@ 2005-09-26 13:14 ` Stefan Monnier
1 sibling, 0 replies; 13+ messages in thread
From: Stefan Monnier @ 2005-09-26 13:14 UTC (permalink / raw)
Cc: emacs-devel
> Because url package was merged into Emacs long time ago, my
> understanding is it's meaningless to do xemacs feature test in url
> codes. So should these test codes be removed?
Maybe you want to fix them so they don't test for (featurep 'xemacs) but for
something more specific. But AFAIK when the code was moved from the URL
project's CVS repository to the Emacs project's CVS repository, the code
worked on XEmacs as well. And it hasn't been changed much since, so it
should either still work under XEmacs, or be close to working. I see no
reason to remove the XEmacs support.
But maybe we should check with the XEmacs guys: if they have their own
version of the URL package, maybe we want to try and resync them, or we may
decide to drop XEmacs support from our version.
In either case, the byte-compiler of Emacs knows that (featurep 'xemacs)
returns nil, so the tests you want to remove from the source code are
already removed during byte-compilation.
Stefan
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2005-10-13 16:07 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-25 17:54 Should xemacs feature test be removed from url package? CHENG Gao
2005-09-26 4:49 ` Richard M. Stallman
2005-09-26 5:04 ` Cheng Gao
2005-09-26 5:14 ` David Kastrup
2005-09-26 23:55 ` Richard M. Stallman
2005-09-26 23:55 ` Richard M. Stallman
2005-09-27 3:16 ` Cheng Gao
2005-09-27 6:42 ` David Kastrup
2005-09-27 15:43 ` Stefan Monnier
2005-09-27 21:58 ` Richard M. Stallman
2005-10-10 23:47 ` Richard M. Stallman
2005-10-13 16:07 ` CHENG Gao
2005-09-26 13:14 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).