unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 'martin rudalics' <rudalics@gmx.at>, 'Emacs-Devel' <emacs-devel@gnu.org>
Subject: Re: predicate group-p to see if a group exists?
Date: Fri, 01 Feb 2008 09:53:49 -0500	[thread overview]
Message-ID: <jwvwspolold.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <002401c864a1$9bce4d00$864a908d@us.oracle.com> (Drew Adams's message of "Thu, 31 Jan 2008 23:11:03 -0800")

> Granted, most users of `defgroup', `defcustom', and `defface' will not need
> to test whether a given group exists, but some will. I still have the
> question whether we shouldn't have a function `group-p'.

IIRC I've looked into it at some point.  The problem is that currently,
the data necessary to write custom-group-p is absent.

`customize-read-group' uses the following predicate for completion
purposes:

                     (lambda (symbol)
                       (or (and (get symbol 'custom-loads)
                                (not (get symbol 'custom-autoload)))
                           (get symbol 'custom-group)))

So we could use the above as the definition of custom-group-p, but IIRC
it's not 100% reliable/correct, and the lack of comments explaining why
we check (and (get symbol 'custom-loads) (not (get symbol 'custom-autoload)))
is also a significant problem.


        Stefan




  reply	other threads:[~2008-02-01 14:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-31 23:03 predicate group-p to see if a group exists? Drew Adams
2008-02-01  6:40 ` martin rudalics
2008-02-01  7:11   ` Drew Adams
2008-02-01 14:53     ` Stefan Monnier [this message]
2008-02-01 15:00       ` Lennart Borgman (gmail)
2008-02-02  7:39     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvwspolold.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).