From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: emacs-pretest-bug@gnu.org
Subject: Re: compilation-next-error - extra `let' binding?
Date: Sat, 09 Feb 2008 22:16:08 -0500 [thread overview]
Message-ID: <jwvwspd5wov.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <005c01c86a82$3803b940$a350908d@us.oracle.com> (Drew Adams's message of "Fri, 8 Feb 2008 10:41:29 -0800")
> Can't tell for sure without checking all of the code called by the
> body of the `let', but it looks like the `let' binding of `loc' in
> `compilation-next-error' is superfluous:
> (let* ((msg (get-text-property pt 'message))
> (loc (car msg)) ; ???????
> last)
> If so, taking out the binding would make the code easier to
> understand. If not, adding a comment for it might make the code easier
> to understand.
It's actually used by the compilation-loop macro.
I've added a comment to this effect.
Stefan
prev parent reply other threads:[~2008-02-10 3:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 18:41 compilation-next-error - extra `let' binding? Drew Adams
2008-02-08 18:49 ` Drew Adams
2008-02-10 3:17 ` Stefan Monnier
2008-02-10 3:16 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwspd5wov.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=drew.adams@oracle.com \
--cc=emacs-pretest-bug@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).