unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: emacs-devel@gnu.org
Subject: Re: Patch: enhanced mark navigation commands
Date: Wed, 05 Mar 2008 14:20:23 -0500	[thread overview]
Message-ID: <jwvwsohj8ux.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <86r6ep8821.fsf@lifelogs.com> (Ted Zlatanov's message of "Wed, 05 Mar 2008 10:11:34 -0600")

AR> The attached lisp allows moving around within a buffer or buffers to
AR> places where recent edits or other events took place.  It has been
AR> part of Emacs.app for a while and users have found it useful; I'd like
AR> to propose it being added to the emacs distribution itself, probably
AR> as part of simple.el.

AR> Specifically, the keys M-p and M-n are bound to move forwards and
AR> backwards through the mark history.  Also, immediately after popping a
AR> global mark, e.g., with C-x C-SPC, then the global mark ring is used.

The functionality looks interesting.  But there are a few problems with it:

- loading the file alters the behavior of Emacs.  The `global-set-key'
  calls should be moved out of the top-level, e.g. into a minor-mode.
- it seems to do some funny dances with the mark-ring and global-mark-ring
  (including reversing them), so I'm not sure the interaction with things
  like C-u C-SPC will be right.
- this last point really means that maybe this should be more closely
  integrated into existing functionality such as C-u C-SPC.  After all,
  C-u C-SPC (and/or C-x C-SPC) offers basically the functionality of
  your `ns-prev-mark' (especially together with
  set-mark-command-repeat-pop).  So all we need is a way to provide
  ns-next-mark.  If the main/only use of ns-next-mark is to undo an
  excessive use of ns-prev-mark, then maybe C-u could be used to
  change the direction in a series of C-SPC:
  C-u C-SPC C-SPC C-SPC ... oh no too far ... C-u C-SPC

> Would next-error and previous-error (which are useful for any motion to
> "points of interest" and have aliases defined accordingly) be
> appropriate here?  They already handle occur-mode, grep-mode, and
> compilation-mode point of interest, and the intent is to provide a DWIM
> interface.

> It makes sense that if any of those three modes are not on, next-error
> and previous-error should move to recent edit points.  If one of those
> modes is on, we can provide an override, but I expect users to be happy
> with the default behavior as I describe it.  What do you think?

And then as soon as you run grep, diff, or compile, the feature just
can't be used any more?  Doesn't sound too good to me,


        Stefan




  reply	other threads:[~2008-03-05 19:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-05  5:12 Patch: enhanced mark navigation commands Adrian Robert
2008-03-05  6:19 ` Miles Bader
2008-03-05 12:23   ` paul r
2008-03-05  6:41 ` Dan Nicolaescu
2008-03-06  0:57   ` Juri Linkov
2008-03-06  1:47     ` Dan Nicolaescu
2008-03-06  7:18       ` Drew Adams
2008-03-06 10:09       ` Juri Linkov
2008-03-09 21:55     ` Juri Linkov
2008-03-05 16:11 ` Ted Zlatanov
2008-03-05 19:20   ` Stefan Monnier [this message]
2008-03-05 19:48     ` Ted Zlatanov
2008-03-05 22:10       ` Miles Bader
2008-03-10 13:09         ` Ted Zlatanov
2008-03-10 22:34           ` Juri Linkov
2008-03-11 15:08             ` Ted Zlatanov
2008-03-06  0:54 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvwsohj8ux.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=tzz@lifelogs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).