From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Recent trunk build crashes a lot under Win32 Date: Thu, 17 Apr 2008 22:26:26 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1208485607 17126 80.91.229.12 (18 Apr 2008 02:26:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 18 Apr 2008 02:26:47 +0000 (UTC) Cc: Claus , Emacs Devel To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 18 04:27:21 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JmgJr-0007xg-JB for ged-emacs-devel@m.gmane.org; Fri, 18 Apr 2008 04:27:19 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JmgJC-0005t8-KM for ged-emacs-devel@m.gmane.org; Thu, 17 Apr 2008 22:26:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JmgJ8-0005st-4J for emacs-devel@gnu.org; Thu, 17 Apr 2008 22:26:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JmgJ6-0005sh-NV for emacs-devel@gnu.org; Thu, 17 Apr 2008 22:26:32 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JmgJ6-0005se-Hk for emacs-devel@gnu.org; Thu, 17 Apr 2008 22:26:32 -0400 Original-Received: from 76-10-171-8.dsl.teksavvy.com ([76.10.171.8] helo=ceviche.home) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JmgJ6-00033U-JF for emacs-devel@gnu.org; Thu, 17 Apr 2008 22:26:32 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 46283B40ED; Thu, 17 Apr 2008 22:26:26 -0400 (EDT) In-Reply-To: (YAMAMOTO Mitsuharu's message of "Wed, 16 Apr 2008 09:41:23 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95424 Archived-At: > I think you mean this part. > 1392 if (!STRING_MULTIBYTE (tem)) > 1393 { > 1394 /* FIXME: DECODE_FILE may GC, which may move SDATA(name), > 1395 after which `nm' won't point to the right place any more. */ > 1396 int offset = nm - SDATA (name); > 1397 hdir = DECODE_FILE (tem); > 1398 newdir = SDATA (hdir); > 1399 nm = SDATA (name) + offset; > 1400 } > But `nm' does not always point to the string data of `name' on some > platforms. > 1160 nm = SDATA (name); > 1161 > 1162 #ifdef DOS_NT > 1163 /* We will force directory separators to be either all \ or /, so make > 1164 a local copy to modify, even if there ends up being no change. */ > 1165 nm = strcpy (alloca (strlen (nm) + 1), nm); Good point. I hope I've fixed it now, Stefan