From: Stefan Monnier <monnier@iro.umontreal.ca>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: Claus <claus.klingberg@gmail.com>, Emacs Devel <emacs-devel@gnu.org>
Subject: Re: Recent trunk build crashes a lot under Win32
Date: Thu, 17 Apr 2008 22:26:26 -0400 [thread overview]
Message-ID: <jwvwsmvew5a.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <wlej96pr64.wl%mituharu@math.s.chiba-u.ac.jp> (YAMAMOTO Mitsuharu's message of "Wed, 16 Apr 2008 09:41:23 +0900")
> I think you mean this part.
> 1392 if (!STRING_MULTIBYTE (tem))
> 1393 {
> 1394 /* FIXME: DECODE_FILE may GC, which may move SDATA(name),
> 1395 after which `nm' won't point to the right place any more. */
> 1396 int offset = nm - SDATA (name);
> 1397 hdir = DECODE_FILE (tem);
> 1398 newdir = SDATA (hdir);
> 1399 nm = SDATA (name) + offset;
> 1400 }
> But `nm' does not always point to the string data of `name' on some
> platforms.
> 1160 nm = SDATA (name);
> 1161
> 1162 #ifdef DOS_NT
> 1163 /* We will force directory separators to be either all \ or /, so make
> 1164 a local copy to modify, even if there ends up being no change. */
> 1165 nm = strcpy (alloca (strlen (nm) + 1), nm);
Good point. I hope I've fixed it now,
Stefan
next prev parent reply other threads:[~2008-04-18 2:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 11:16 Recent trunk build crashes a lot under Win32 Claus
2008-04-15 11:54 ` Jason Rumney
2008-04-15 15:18 ` Claus
2008-04-15 16:24 ` Claus
2008-04-15 22:07 ` Jason Rumney
2008-04-15 15:07 ` Kyle M. Lee
2008-04-15 17:01 ` Stefan Monnier
2008-04-16 0:41 ` YAMAMOTO Mitsuharu
2008-04-18 2:26 ` Stefan Monnier [this message]
2008-04-19 20:28 ` Claus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwsmvew5a.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=claus.klingberg@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).