Re: Patch Makefile.in to remove .DS_Store on MacOSX

Re: Patch Makefile.in to remove .DS_Store on MacOSX

[Seiji Zenitani]

CHENG Gao wrote:
 >
 > Attached is patch file to remove .DS_Store (on MacOSX) while  
installing
 > Emacs.
 >
 > --- Makefile.in.old     2009-08-13 22:15:27.000000000 +0800
 > +++ Makefile.in 2009-08-13 22:13:14.000000000 +0800
 > @@ -486,6 +486,7 @@
 >                 chmod a+rx $${subdir} ; \
 >                 rm -rf $${subdir}/RCS ; \
 >                 rm -rf $${subdir}/CVS ; \
 > +               rm -f  $${subdir}/.DS_Store ; \
 >                 rm -f  $${subdir}/.cvsignore ; \
 >                 rm -f  $${subdir}/.gitignore ; \
 >                 rm -f  $${subdir}/.arch-inventory ; \

I think this proposal is reasonable.

The .DS_Store is a meta file to store GUI-related information
(size, position of the window or icon's position in the window),
and it is automatically generated by Finder (the file browser).

Can I install this?

Seiji

Re: Patch Makefile.in to remove .DS_Store on MacOSX

[Chong Yidong]

Seiji Zenitani <zenitani@mac.com> writes:

> I think this proposal is reasonable.
>
> The .DS_Store is a meta file to store GUI-related information
> (size, position of the window or icon's position in the window),
> and it is automatically generated by Finder (the file browser).
>
> Can I install this?

OK.

Re: Patch Makefile.in to remove .DS_Store on MacOSX

[Seiji Zenitani]

On 2009/08/15, at 21:29, Chong Yidong wrote:

> Seiji Zenitani <zenitani@mac.com> writes:
>
>> I think this proposal is reasonable.
>>
>> The .DS_Store is a meta file to store GUI-related information
>> (size, position of the window or icon's position in the window),
>> and it is automatically generated by Finder (the file browser).
>>
>> Can I install this?
>
> OK.

Done.

Re: Patch Makefile.in to remove .DS_Store on MacOSX

[Christian Lynbech]

Could we get .svn added to the list? If we are already removing CVS and
RCS and what not, it would be really usefull (to me at least :-) to also
cover subversions meta directories.


------------------------+-----------------------------------------------------
Christian Lynbech       | christian #\@ defun #\. dk
------------------------+-----------------------------------------------------
Hit the philistines three times over the head with the Elisp reference manual.
                                        - petonic@hal.com (Michael A. Petonic)

Re: Patch Makefile.in to remove .DS_Store on MacOSX

[Seiji Zenitani]

I don't think .svn needs to be added.
We use CVS, git or bzr to develop Emacs,
but we don't use subversion.

Seiji

On 2009/08/16, at 12:55, Christian Lynbech wrote:

> Could we get .svn added to the list? If we are already removing CVS  
> and
> RCS and what not, it would be really usefull (to me at least :-) to  
> also
> cover subversions meta directories.
>
>
> ------------------------ 
> +-----------------------------------------------------
> Christian Lynbech       | christian #\@ defun #\. dk
> ------------------------ 
> +-----------------------------------------------------
> Hit the philistines three times over the head with the Elisp  
> reference manual.
>                                        - petonic@hal.com (Michael A.  
> Petonic)

Re: Patch Makefile.in to remove .DS_Store on MacOSX

[Ken Raeburn]

On Aug 17, 2009, at 20:54, Seiji Zenitani wrote:
> I don't think .svn needs to be added.
> We use CVS, git or bzr to develop Emacs,
> but we don't use subversion.

Who's "we"?  I was using subversion for quite a while to manage my  
local development tree.  I just couldn't use it directly from the FSF  
machines; I had to do my own mirroring.  And I did, in fact, keep  
deletion of .svn subdirectories as one of my local changes as a result.

Any setup where directories are copied wholesale from the source tree  
to the installation tree is likely to encounter such problems with  
artifacts from different environments -- .DS_Store files, VCS files or  
directories, editor backup files, etc.  It might be cleaner to copy  
only the things we want; if not with a complete list of names, then  
perhaps a list of suffixes, or directory names and suffixes, or some  
such.

Ken

Re: Patch Makefile.in to remove .DS_Store on MacOSX

[Stefan Monnier]

> Who's "we"?  I was using subversion for quite a while to manage my local
> development tree.  I just couldn't use it directly from the FSF  machines;
> I had to do my own mirroring.  And I did, in fact, keep  deletion of .svn
> subdirectories as one of my local changes as a result.

That doesn't seem like a problem: the whole reason for you to use such
a VCS was to keep track of local changes, so handling local changes is
obviously not a problem.


        Stefan

Re: Patch Makefile.in to remove .DS_Store on MacOSX

[Lynbech Christian]

>>>>> "Stefan" == Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

Stefan> That doesn't seem like a problem: the whole reason for you to use such
Stefan> a VCS was to keep track of local changes, so handling local changes is
Stefan> obviously not a problem.

I too track emacs using a local subversion repository, hence the request.

I just noted that the current list of deletions included several things
obviously not in current use by the emacs developers such as RCS
directories.

Would it be terribly inconvenient to add .svn as well?


------------------------+-----------------------------------------------------
Christian Lynbech       | christian #\@ defun #\. dk
------------------------+-----------------------------------------------------
Hit the philistines three times over the head with the Elisp reference manual.
                                        - petonic@hal.com (Michael A. Petonic)

Re: Patch Makefile.in to remove .DS_Store on MacOSX

[Stefan Monnier]

Stefan> That doesn't seem like a problem: the whole reason for you to use such
Stefan> a VCS was to keep track of local changes, so handling local changes is
Stefan> obviously not a problem.

> I too track emacs using a local subversion repository, hence the request.

> I just noted that the current list of deletions included several things
> obviously not in current use by the emacs developers such as RCS
> directories.

> Would it be terribly inconvenient to add .svn as well?

I'd rather remove RCS, to tell you the truth,


        Stefan

Re: Patch Makefile.in to remove .DS_Store on MacOSX

[Ken Raeburn]

On Aug 18, 2009, at 10:25, Stefan Monnier wrote:
>> Who's "we"?  I was using subversion for quite a while to manage my  
>> local
>> development tree.  I just couldn't use it directly from the FSF   
>> machines;
>> I had to do my own mirroring.  And I did, in fact, keep  deletion  
>> of .svn
>> subdirectories as one of my local changes as a result.
>
> That doesn't seem like a problem: the whole reason for you to use such
> a VCS was to keep track of local changes, so handling local changes is
> obviously not a problem.

Sure, it worked, but we could either make it unnecessary (by copying  
just the desired files or file name patterns), or make it easier to  
change the list to be removed after copying.  Currently it's buried  
down in one of many multi-line commands in a makefile target for which  
the rules are over 130 lines long.  And if it's a directory you need  
to add to the list, actually you probably want to make two changes,  
one to delete it, and one to get 'find' to not look around inside it  
for more things to delete explicitly.

Ken

Re: Patch Makefile.in to remove .DS_Store on MacOSX

[Christian Lynbech]

[unsure if this got through, sending again]
>>>>> "Seiji" == Seiji Zenitani <zenitani@mac.com> writes:

Seiji> We use CVS, git or bzr to develop Emacs,
Seiji> but we don't use subversion.

But the current list of stuff removed contains more than what is
currently used by the emacs developers, for instance RCS directories are
also removed.

I use subversion for tracking emacs releases, hence the request.

Would it be terribly inconvenient to add .svn to the list?


------------------------+-----------------------------------------------------
Christian Lynbech       | christian #\@ defun #\. dk
------------------------+-----------------------------------------------------
Hit the philistines three times over the head with the Elisp reference manual.
                                        - petonic@hal.com (Michael A. Petonic)

Re: Patch Makefile.in to remove .DS_Store on MacOSX

[Seiji Zenitani]

On 2009/08/18, at 17:24, Christian Lynbech wrote:

> [unsure if this got through, sending again]
>>>>>> "Seiji" == Seiji Zenitani <zenitani@mac.com> writes:
>
> Seiji> We use CVS, git or bzr to develop Emacs,
> Seiji> but we don't use subversion.
>
> But the current list of stuff removed contains more than what is
> currently used by the emacs developers, for instance RCS directories  
> are
> also removed.
>
> I use subversion for tracking emacs releases, hence the request.
>
> Would it be terribly inconvenient to add .svn to the list?

In my opinion, the best solution is
to modify Makefile.in in your local repository.
I am not willing to modify the official one
for an unsupported VCS.

It is certainly strange that the list contains RCS.
Probably it needs to be removed.

--- Makefile.in	16 Aug 2009 03:16:34 -0000	1.375
+++ Makefile.in	20 Aug 2009 00:56:21 -0000
@@ -482,9 +482,8 @@
		| (cd $${dest}; umask 022; \
                    tar -xvf - && cat > /dev/null) || exit 1; \
	      find $${dest} -exec chown $${installuser} {} ';' ;\
-	      for subdir in `find $${dest} -type d ! -name RCS ! -name CVS - 
print` ; do \
+	      for subdir in `find $${dest} -type d ! -name CVS -print` ; do \
		chmod a+rx $${subdir} ; \
-		rm -rf $${subdir}/RCS ; \
		rm -rf $${subdir}/CVS ; \
		rm -f  $${subdir}/.cvsignore ; \
		rm -f  $${subdir}/.gitignore ; \


Seiji

Patch Makefile.in to remove .DS_Store on MacOSX

[CHENG Gao]

[-- Attachment #1: Type: text/plain, Size: 81 bytes --]


Attached is patch file to remove .DS_Store (on MacOSX) while installing
Emacs.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Makefile.in.diff --]
[-- Type: text/x-patch, Size: 363 bytes --]

--- Makefile.in.old	2009-08-13 22:15:27.000000000 +0800
+++ Makefile.in	2009-08-13 22:13:14.000000000 +0800
@@ -486,6 +486,7 @@
 		chmod a+rx $${subdir} ; \
 		rm -rf $${subdir}/RCS ; \
 		rm -rf $${subdir}/CVS ; \
+		rm -f  $${subdir}/.DS_Store ; \
 		rm -f  $${subdir}/.cvsignore ; \
 		rm -f  $${subdir}/.gitignore ; \
 		rm -f  $${subdir}/.arch-inventory ; \