From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: switch-to-completions Date: Wed, 18 Nov 2009 20:12:11 -0500 Message-ID: References: <61C01A08-8FB6-4908-B9F1-B9F1CE3E3D92@gmail.com> <20091111212658.GD12012@headley> <87fx8kjosa.fsf_-_@mail.jurta.org> <7b501d5c0911120209x7c8f493fm68fadef6f1311206@mail.gmail.com> <87bpj16pkh.fsf@mail.jurta.org> <87hbssw5xd.fsf_-_@mail.jurta.org> <87einv3e14.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1258594372 9788 80.91.229.12 (19 Nov 2009 01:32:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Nov 2009 01:32:52 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 19 02:32:45 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NAvt7-0008Ox-Jb for ged-emacs-devel@m.gmane.org; Thu, 19 Nov 2009 02:32:45 +0100 Original-Received: from localhost ([127.0.0.1]:37814 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NAvt7-0007HI-0J for ged-emacs-devel@m.gmane.org; Wed, 18 Nov 2009 20:32:45 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NAvZK-0005pW-7J for emacs-devel@gnu.org; Wed, 18 Nov 2009 20:12:18 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NAvZF-0005me-H0 for emacs-devel@gnu.org; Wed, 18 Nov 2009 20:12:17 -0500 Original-Received: from [199.232.76.173] (port=59238 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NAvZF-0005mR-C3 for emacs-devel@gnu.org; Wed, 18 Nov 2009 20:12:13 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:57018 helo=ironport2-out.pppoe.ca) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NAvZF-0000Tq-38 for emacs-devel@gnu.org; Wed, 18 Nov 2009 20:12:13 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAGsqBEvO+IIa/2dsb2JhbACBTdcvhDsEiVc X-IronPort-AV: E=Sophos;i="4.44,767,1249272000"; d="scan'208";a="49632422" Original-Received: from 206-248-130-26.dsl.teksavvy.com (HELO pastel.home) ([206.248.130.26]) by ironport2-out.pppoe.ca with ESMTP; 18 Nov 2009 20:12:12 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 127D28774; Wed, 18 Nov 2009 20:12:12 -0500 (EST) In-Reply-To: <87einv3e14.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 18 Nov 2009 21:04:36 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:117225 Archived-At: > I'm not sure what function should take care about finding the right place > since creation of the *Completions* buffer is shared among several functions: > `display-completion-list' inserts the text "Possible completions are:\n", > `completion-setup-function' inserts the help text with one newline or > two newlines depending on `(display-mouse-p)' or no help text if > `completion-show-help' is nil. Good point, maybe minibuffer-completion-help is not the best place, but it's closer than switch-to-completions. > And there are many packages that > don't call `minibuffer-completion-help' - they use something like > (with-output-to-temp-buffer "*Completions*" (display-completion-list ... Yes, this redundancy sucks, but it's another problem. > Maybe `switch-to-completions' should simply call `(next-completion 1)'? > It seems this is the most reliable way to move point to the first completion. Fine by me. Install your patch for now, but please include a comment explaining that the cursor-movement should really be done elsewhere. Stefan