From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Passing flags using vc-do-command Date: Mon, 14 Mar 2011 22:06:56 -0400 Message-ID: References: <87lj0qstpw.fsf@speer.lan> <87lj0oyfar.fsf@speer.lan> <87mxl0pwqj.fsf@speer.lan> <8762rlenqk.fsf@speer.lan> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1300154836 18644 80.91.229.12 (15 Mar 2011 02:07:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 15 Mar 2011 02:07:16 +0000 (UTC) Cc: Andy Moreton , emacs-devel@gnu.org To: Lute Kamstra Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 15 03:07:11 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PzJfD-0005S4-0f for ged-emacs-devel@m.gmane.org; Tue, 15 Mar 2011 03:07:11 +0100 Original-Received: from localhost ([127.0.0.1]:50850 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzJfC-0006n7-8D for ged-emacs-devel@m.gmane.org; Mon, 14 Mar 2011 22:07:10 -0400 Original-Received: from [140.186.70.92] (port=38614 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzJf4-0006lZ-IW for emacs-devel@gnu.org; Mon, 14 Mar 2011 22:07:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzJez-0007f1-Uj for emacs-devel@gnu.org; Mon, 14 Mar 2011 22:07:02 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:37330 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzJez-0007eX-Ry for emacs-devel@gnu.org; Mon, 14 Mar 2011 22:06:57 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAOlmfk1FxIRf/2dsb2JhbACmDXiwFpIshWIElUw X-IronPort-AV: E=Sophos;i="4.62,319,1297054800"; d="scan'208";a="96525023" Original-Received: from 69-196-132-95.dsl.teksavvy.com (HELO pastel.home) ([69.196.132.95]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 14 Mar 2011 22:06:56 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 2ED8E58ED9; Mon, 14 Mar 2011 22:06:56 -0400 (EDT) In-Reply-To: <8762rlenqk.fsf@speer.lan> (Lute Kamstra's message of "Mon, 14 Mar 2011 16:16:35 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137232 Archived-At: > I'm open to suggestions for a better name... There's a lot of freedom here: vc-run, vc-run-process, vc-run-command, vc-do-process, vc-call-process, ... > But maybe it's cleaner to make an incompatible change and just replace > vc-do-command. You don't have throw away vc-do-command right away, but yes, make a brand new command without paying attention to vc-do-command, adding the features that would be handy, and maybe dropping some that aren't needed any more. It should pay particular attention to asynchronous execution, since more commands should be changed (in the future) to use asynchronous execution, and that feature was added to vc-do-command "with minimal changes" which ends up not being always the most convenient. > I could take a look at the current uses of vc-do-command / call-process > / start-process in the various backends in trunk to see if I can > accommodate for possible other shortcomings of the current version. But > I'd appreciate some help with that: If people could give me concrete > examples of useful additions, that would be great. As mentioned I think it should centralize/unify the handling of vc--program, and maybe also some of the handling of vc--switches. Stefan