From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lute Kamstra <Lute.Kamstra.lists@xs4all.nl>
Cc: Andy Moreton <andrewjmoreton@gmail.com>, emacs-devel@gnu.org
Subject: Re: Passing flags using vc-do-command
Date: Mon, 14 Mar 2011 22:06:56 -0400 [thread overview]
Message-ID: <jwvwrk15fdd.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8762rlenqk.fsf@speer.lan> (Lute Kamstra's message of "Mon, 14 Mar 2011 16:16:35 +0100")
> I'm open to suggestions for a better name...
There's a lot of freedom here: vc-run, vc-run-process, vc-run-command,
vc-do-process, vc-call-process, ...
> But maybe it's cleaner to make an incompatible change and just replace
> vc-do-command.
You don't have throw away vc-do-command right away, but yes, make
a brand new command without paying attention to vc-do-command, adding
the features that would be handy, and maybe dropping some that aren't
needed any more.
It should pay particular attention to asynchronous execution, since more
commands should be changed (in the future) to use asynchronous
execution, and that feature was added to vc-do-command "with minimal
changes" which ends up not being always the most convenient.
> I could take a look at the current uses of vc-do-command / call-process
> / start-process in the various backends in trunk to see if I can
> accommodate for possible other shortcomings of the current version. But
> I'd appreciate some help with that: If people could give me concrete
> examples of useful additions, that would be great.
As mentioned I think it should centralize/unify the handling of
vc-<backend>-program, and maybe also some of the handling of
vc-<foo>-switches.
Stefan
prev parent reply other threads:[~2011-03-15 2:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 17:53 Passing flags using vc-do-command Lute Kamstra
2011-03-07 23:02 ` Stefan Monnier
2011-03-09 6:32 ` Lute Kamstra
2011-03-09 18:21 ` Stefan Monnier
2011-03-10 13:58 ` Andy Moreton
2011-03-11 1:52 ` Stefan Monnier
2011-03-12 8:40 ` Lute Kamstra
2011-03-12 8:29 ` Lute Kamstra
2011-03-14 11:35 ` Lute Kamstra
2011-03-14 13:43 ` Stefan Monnier
2011-03-14 15:16 ` Lute Kamstra
2011-03-15 2:06 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwrk15fdd.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=Lute.Kamstra.lists@xs4all.nl \
--cc=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).