From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: patch for completion in octave Date: Mon, 25 Apr 2011 13:32:47 -0300 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1303749186 12998 80.91.229.12 (25 Apr 2011 16:33:06 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 25 Apr 2011 16:33:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: Alexander Klimov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 25 18:33:02 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QEOia-0001MX-S2 for ged-emacs-devel@m.gmane.org; Mon, 25 Apr 2011 18:33:00 +0200 Original-Received: from localhost ([::1]:44644 helo=lists2.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEOia-0007Vn-IE for ged-emacs-devel@m.gmane.org; Mon, 25 Apr 2011 12:33:00 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:57441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEOiU-0007Ug-IG for emacs-devel@gnu.org; Mon, 25 Apr 2011 12:32:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QEOiT-0001OZ-Kh for emacs-devel@gnu.org; Mon, 25 Apr 2011 12:32:54 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:49292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEOiT-0001OT-Hy for emacs-devel@gnu.org; Mon, 25 Apr 2011 12:32:53 -0400 Original-Received: from 121-249-126-200.fibertel.com.ar ([200.126.249.121]:37107 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QEOiR-0000h0-0G; Mon, 25 Apr 2011 12:32:51 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 78E596610E; Mon, 25 Apr 2011 13:32:47 -0300 (ART) In-Reply-To: (Alexander Klimov's message of "Wed, 9 Feb 2011 16:00:23 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:138739 Archived-At: >> So, could you try the patch below instead for a little while and see if >> it fixes your problem (it should) and if it doesn't introduce >> other issues? > Your patch is also a good idea since it removes a code duplication, > but besides fixing the original problem, it evinces that we have > (modify-syntax-entry ?. "w" table) > (modify-syntax-entry ?_ "w" table) > in octave-mod.el, that makes M-f or M-b on something like I've installed a patch which should fix this, along with the poriginal completion problem in octave-inf. > In the menu "Lookup Octave Index" does not work since info-lookup-mode > is not set (maybe we should set lookup mode "globally" instead and > remove octave-help?). I've set info-lookup-mode in inferior-actave-mode indeed, so that the standard binding for info-lookup-symbol (C-h S) works. > There is also a problem with completion-addsuffix, since `v' > gives `var ' and now the user has to press DEL to continue with > `.field' (btw, since the structure completion is possible, I added `.' > into the skip pattern below). The new code does not use comint's comint-dynamic-simple-complete but also gets rid of the addsuffix. This may not always be the right thing to do (it's sometimes convenient to have the SPC suffix), but until we can determine when it's good and when it's not, I'd rather not add any. Stefan