From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: sds@gnu.org, emacs-devel@gnu.org
Subject: Re: convert-standard-filename
Date: Sun, 07 Aug 2011 16:19:47 -0400 [thread overview]
Message-ID: <jwvwrepkntu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <834o1t19hg.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 07 Aug 2011 19:18:03 +0300")
>> >> But how should it decide what is relative and what is not, e.g. in the
>> >> case of "c:/foo" (or worse "c:foo") mentioned in the docstring?
>> > Why by file-name-absolute-p, of course ;-)
>> This would mean that the input is interpreted in an OS-dependent way.
>> It would seem to make more sense to say that the arg to
>> convert-filename-argument (or its new replacement) should be
>> a Unix-style filename, i.e. "C:<foo>" is always interpreted as
>> a relative file name, even under Window or DOS.
> Although it makes sense, that would change the current semantics, and
> probably break some existing code out there.
Agreed. I think that not only convert-standard-filename has drifted far
from its original purpose, but to fix it we need to define a new
function because too many callers require a behavior that's incompatible
with "the right convert-standard-filename".
>> How 'bout a file-name-equal, which could also try to account for
>> case-sensitivity?
> He-he, I was arguing for years that file names are not strings and
> cannot be compared as strings. Finally I have someone who agrees ;-)
I always thought you weren't completely convinced. I'm all for it.
We do want to define it carefully, tho. E.g. it should only operate on
names without performing any actual file/directory lookup.
>> Hmm... I didn't check all uses of doc-8+3-filename, but at least the one
>> in files.el can't be replaced by file-name-equal.
> They all can. dos-8+3-filename was introduced _only_ to be able to
> compare and match file names as strings.
The use in files.el is to generate a good backup file name, presumably
because "#foobar.perl#" would get turned into "#foobar.per" whereas we
prefer "#foobar.pe#". I don't know how to do that with file-name-equal,
but admittedly, dos-8+3-filename is not sufficient to do it either: it
uses ad-hoc code in files.el.
Stefan
next prev parent reply other threads:[~2011-08-07 20:19 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1QjaPL-0003HL-TM@colonialone.fsf.org>
2011-08-02 3:39 ` [Emacs-diffs] /srv/bzr/emacs/trunk r105295: * lisp/progmodes/etags.el (etags-file-of-tag, etags-tags-table-files) Stefan Monnier
2011-08-02 4:34 ` Sam Steingold
2011-08-02 4:51 ` Eli Zaretskii
2011-08-02 18:57 ` Stefan Monnier
2011-08-02 19:12 ` Eli Zaretskii
2011-08-02 20:24 ` Stefan Monnier
2011-08-03 9:05 ` Eli Zaretskii
2011-08-05 17:18 ` convert-standard-filename (was: [Emacs-diffs] /srv/bzr/emacs/trunk r105295: * lisp/progmodes/etags.el (etags-file-of-tag, etags-tags-table-files)) Stefan Monnier
2011-08-06 7:20 ` Eli Zaretskii
2011-08-07 15:33 ` convert-standard-filename Stefan Monnier
2011-08-07 15:43 ` convert-standard-filename Lennart Borgman
2011-08-07 19:43 ` convert-standard-filename Stefan Monnier
2011-08-07 22:05 ` convert-standard-filename Lennart Borgman
2011-08-08 2:54 ` convert-standard-filename Eli Zaretskii
2011-08-08 3:23 ` convert-standard-filename Lennart Borgman
2011-08-08 4:19 ` convert-standard-filename Eli Zaretskii
2011-08-08 4:26 ` convert-standard-filename Lennart Borgman
2011-08-08 4:38 ` convert-standard-filename Eli Zaretskii
2011-08-08 10:37 ` convert-standard-filename Lennart Borgman
2011-08-08 11:31 ` convert-standard-filename Eli Zaretskii
2011-08-08 17:15 ` convert-standard-filename Lennart Borgman
2011-08-07 16:18 ` convert-standard-filename Eli Zaretskii
2011-08-07 16:22 ` convert-standard-filename Lennart Borgman
2011-08-07 20:19 ` Stefan Monnier [this message]
2011-08-07 20:35 ` convert-standard-filename Eli Zaretskii
2011-08-07 21:20 ` convert-standard-filename Sam Steingold
2011-08-08 2:53 ` convert-standard-filename Eli Zaretskii
2011-08-08 3:24 ` convert-standard-filename Stefan Monnier
2011-08-08 4:14 ` convert-standard-filename Eli Zaretskii
2011-08-08 18:20 ` convert-standard-filename Stefan Monnier
2011-08-08 19:14 ` convert-standard-filename Eli Zaretskii
2011-08-08 21:24 ` convert-standard-filename Stefan Monnier
2011-08-09 5:19 ` convert-standard-filename Eli Zaretskii
2011-08-09 18:33 ` convert-standard-filename Stefan Monnier
2011-08-09 18:36 ` convert-standard-filename Stefan Monnier
2011-08-08 7:33 ` convert-standard-filename Michael Albinus
2011-08-02 8:11 ` [Emacs-diffs] /srv/bzr/emacs/trunk r105295: * lisp/progmodes/etags.el (etags-file-of-tag, etags-tags-table-files) Francesco Potortì
2011-08-02 15:33 ` Sam Steingold
2011-08-02 18:55 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwrepkntu.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=sds@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).