unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Chong Yidong <cyd@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: toggle-read-only should not give compilation warnings
Date: Sun, 15 Jul 2012 18:01:44 -0400	[thread overview]
Message-ID: <jwvwr24hef7.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87obnjai2i.fsf@gnu.org> (Chong Yidong's message of "Fri, 13 Jul 2012 21:47:49 +0800")

>> Once we're sure that the remaining calls to toggle-read-only are all
>> "correct", we should try to understand why that is and provide some
>> alternative function for that (and make toggle-read-only use that
>> function, of course).
> It's not difficult to see why the remaining calls are correct: they want
> to do the same thing as C-x C-q, either acting on a different buffer or
> with a different interactive invocation.  Examples include
> mode-line-toggle-read-only and Buffer-menu-toggle-read-only.
> Adding another function, rather than simply using toggle-read-only, is
> an unnecessary level of indirection.

Even better.


        Stefan



  reply	other threads:[~2012-07-15 22:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11  4:11 toggle-read-only should not give compilation warnings Chong Yidong
2012-07-11 16:23 ` Samuel Bronson
2012-07-11 17:04 ` Achim Gratz
2012-07-11 18:22 ` Glenn Morris
2012-07-13  5:22   ` Chong Yidong
2012-07-13  6:03     ` Drew Adams
2012-07-13 13:04     ` Stefan Monnier
2012-07-13 13:47       ` Chong Yidong
2012-07-15 22:01         ` Stefan Monnier [this message]
2012-07-12  0:58 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvwr24hef7.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=cyd@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).