From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Recent read-face patch breaks `M-x customize-face' Date: Fri, 05 Apr 2013 17:40:30 -0400 Message-ID: References: <20130405175032.GA29138@saturn> <20831.7759.573008.165973@gargle.gargle.HOWL> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1365278604 29287 80.91.229.3 (6 Apr 2013 20:03:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Apr 2013 20:03:24 +0000 (UTC) Cc: Giorgos Keramidas , emacs-devel@gnu.org To: "Roland Winkler" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 06 22:03:22 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UOZJA-0001KY-PB for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2013 22:01:52 +0200 Original-Received: from localhost ([::1]:48516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOENF-0005Ca-J1 for ged-emacs-devel@m.gmane.org; Fri, 05 Apr 2013 17:40:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOENB-0005CV-DZ for emacs-devel@gnu.org; Fri, 05 Apr 2013 17:40:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UOEN5-0003XI-TX for emacs-devel@gnu.org; Fri, 05 Apr 2013 17:40:37 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:3609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOEN5-0003XC-GL; Fri, 05 Apr 2013 17:40:31 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFxLSu/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOkeoFegxM X-IPAS-Result: Av4EABK/CFFFxLSu/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="6603508" Original-Received: from 69-196-180-174.dsl.teksavvy.com (HELO pastel.home) ([69.196.180.174]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 05 Apr 2013 17:40:27 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 3915367A24; Fri, 5 Apr 2013 17:40:30 -0400 (EDT) In-Reply-To: <20831.7759.573008.165973@gargle.gargle.HOWL> (Roland Winkler's message of "Fri, 5 Apr 2013 13:56:15 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158712 Archived-At: > When I installed the patch, I somehow overlooked that customize-face > calls read-face-name with DEFAULT having the value "all faces". > This is certainly not a very meaningful value to begin with. > So I guess the best fix is to replace "all faces" by nil. It would be safer to simply turn any non-list value of `default' into a one-element list. Stefan