From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r117640: * keyboard.c (safe_run_hook_funcall): Avoid consing around Date: Mon, 04 Aug 2014 18:35:56 -0400 Message-ID: References: <53DF4423.6050101@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1407191786 24941 80.91.229.3 (4 Aug 2014 22:36:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Aug 2014 22:36:26 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 05 00:36:19 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XEQrY-0007p9-DJ for ged-emacs-devel@m.gmane.org; Tue, 05 Aug 2014 00:36:16 +0200 Original-Received: from localhost ([::1]:55237 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEQrY-0006xd-0I for ged-emacs-devel@m.gmane.org; Mon, 04 Aug 2014 18:36:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEQrN-0006pT-Ao for emacs-devel@gnu.org; Mon, 04 Aug 2014 18:36:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEQrF-0002j2-Rx for emacs-devel@gnu.org; Mon, 04 Aug 2014 18:36:05 -0400 Original-Received: from smtp-pri-02-2.vtxnet.net ([212.147.62.156]:48363 helo=smtp-pri-02.vtxnet.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEQrF-0002ii-LC for emacs-devel@gnu.org; Mon, 04 Aug 2014 18:35:57 -0400 Original-Received: from fmsmemgm.homelinux.net (dyn.83-228-141-040.dsl.vtx.ch [83.228.141.40]) by smtp-pri-02.vtxnet.net (VTX Services SA) with ESMTP id 7256637DE59; Tue, 5 Aug 2014 00:35:56 +0200 (CEST) Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 190DDAE0C1; Mon, 4 Aug 2014 18:35:56 -0400 (EDT) In-Reply-To: <53DF4423.6050101@yandex.ru> (Dmitry Antipov's message of "Mon, 04 Aug 2014 12:28:19 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 212.147.62.156 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:173418 Archived-At: >> You remove the comment but don't fix the code accordingly: if the FIXME >> is not valid any more, than we should cleanly pass `hook' as argument >> rather than let-binding it to inhibit-quit. > Hm...isn't it required to bind inhibit-quit to non-nil value before running > hooks? Yes, binding it to a non-nil value is necessary. But that doesn't mean that hook needs to be passed via that dynamic var. Stefan