From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] A few cl-lib tests Date: Mon, 09 Mar 2015 22:30:23 -0400 Message-ID: References: <54E7C046.2050908@cumego.com> <54E91397.7080204@cumego.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1425954653 3009 80.91.229.3 (10 Mar 2015 02:30:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Mar 2015 02:30:53 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?utf-8?Q?Przemys=C5=82aw?= Wojnowski Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 10 03:30:41 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YV9wM-0005CW-VI for ged-emacs-devel@m.gmane.org; Tue, 10 Mar 2015 03:30:39 +0100 Original-Received: from localhost ([::1]:46189 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YV9wM-0001Lp-57 for ged-emacs-devel@m.gmane.org; Mon, 09 Mar 2015 22:30:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YV9wD-0001Lh-Be for emacs-devel@gnu.org; Mon, 09 Mar 2015 22:30:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YV9w8-0006Hu-Bu for emacs-devel@gnu.org; Mon, 09 Mar 2015 22:30:29 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:19934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YV9w8-0006HW-8F for emacs-devel@gnu.org; Mon, 09 Mar 2015 22:30:24 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApAUAPOG1lRLd/0j/2dsb2JhbABbgwaBLIIzhVPAZQQCAoENRAEBAQEBAXyEDQEEAVYjBQsLNBIUGA0kE4glCLtJkloBAQEBBgEBAQEejxYRAVAHhCoFhRQ+jw6Ef4MDixeBeYFFIoICHIFsIjGBC4E3AQEB X-IPAS-Result: ApAUAPOG1lRLd/0j/2dsb2JhbABbgwaBLIIzhVPAZQQCAoENRAEBAQEBAXyEDQEEAVYjBQsLNBIUGA0kE4glCLtJkloBAQEBBgEBAQEejxYRAVAHhCoFhRQ+jw6Ef4MDixeBeYFFIoICHIFsIjGBC4E3AQEB X-IronPort-AV: E=Sophos;i="5.09,536,1418101200"; d="scan'208";a="113135316" Original-Received: from 75-119-253-35.dsl.teksavvy.com (HELO pastel.home) ([75.119.253.35]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 09 Mar 2015 22:30:23 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 395DC111C; Mon, 9 Mar 2015 22:30:23 -0400 (EDT) In-Reply-To: <54E91397.7080204@cumego.com> (=?utf-8?Q?=22Przemys=C5=82aw?= Wojnowski"'s message of "Sun, 22 Feb 2015 00:24:07 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183758 Archived-At: [ Sorry for the delay. ] > Thanks for feedback. I've corrected the tests. Now they use cl-values > when expected. I split them into two groups: working tests and those > that suppose to work, but do to lack of support for multiple values > they don't. If at some point multiple values will be implemented, then > those tests can be moved to the first group. Is that ok? Looks good, thank you. > BTW I'm contributing for the first time here and I'm not really sure > what is the next action after sending a patch... If it cannot be > committed for some reason I would like to know why, for example: "We > can't add it because of... When you fix it we will commit it to the > repository." or "We won't add it no matter what." (it's still better > than no feedback :-) ). I just looked at it and it looks fine. But before we can accept your contribution we'd need you to sign some copyright paperwork. If you're OK with it, then please fill the form below and email it to the FSF so they can send you the relevant paperwork to sign, Stefan Please email the following information to assign@gnu.org, and we will send you the assignment form for your past and future changes. Please use your full legal name (in ASCII characters) as the subject line of the message. ---------------------------------------------------------------------- REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES [What is the name of the program or package you're contributing to?] Emacs [Did you copy any files or text written by someone else in these changes? Even if that material is free software, we need to know about it.] [Do you have an employer who might have a basis to claim to own your changes? Do you attend a school which might make such a claim?] [For the copyright registration, what country are you a citizen of?] [What year were you born?] [Please write your email address here.] [Please write your postal address here.] [Which files have you changed so far, and which new files have you written so far?]