From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 0382fd4: xref-find-definitions: Exclude more generic function items. Date: Thu, 13 Aug 2015 17:14:15 -0400 Message-ID: References: <20150813182108.2057.52629@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1439500479 11836 80.91.229.3 (13 Aug 2015 21:14:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Aug 2015 21:14:39 +0000 (UTC) Cc: Stephen Leake To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 13 23:14:30 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZPzpS-0000Hc-O1 for ged-emacs-devel@m.gmane.org; Thu, 13 Aug 2015 23:14:26 +0200 Original-Received: from localhost ([::1]:44164 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPzpS-0000q1-2Q for ged-emacs-devel@m.gmane.org; Thu, 13 Aug 2015 17:14:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPzpP-0000pv-8g for emacs-devel@gnu.org; Thu, 13 Aug 2015 17:14:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPzpK-0001i3-04 for emacs-devel@gnu.org; Thu, 13 Aug 2015 17:14:23 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:60568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPzpJ-0001hi-R3 for emacs-devel@gnu.org; Thu, 13 Aug 2015 17:14:17 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.DIT.UMontreal.CA (8.14.1/8.14.1) with ESMTP id t7DLEBsM013092; Thu, 13 Aug 2015 17:14:11 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 78B6766132; Thu, 13 Aug 2015 17:14:15 -0400 (EDT) In-Reply-To: (Stephen Leake's message of "Thu, 13 Aug 2015 18:21:08 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5397=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5397> : inlines <3640> : streams <1487883> : uri <2013682> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188784 Archived-At: > +(defcustom find-feature-regexp > + (concat ";;; Code:") FWIW, I think this is overkill and marginally incorrect. (require 'foo) is Elisp's way to "include" a file, so xref should just jump to this file's buffer rather than to a specific location within that file. Just like ffap does in a #include. Stefan