From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master a3b2101 1/2: New file with obarray functions. Date: Wed, 11 Nov 2015 15:26:53 -0500 Message-ID: References: <20151111165602.28114.31123@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1447273642 15272 80.91.229.3 (11 Nov 2015 20:27:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Nov 2015 20:27:22 +0000 (UTC) Cc: =?utf-8?Q?Przemys=C5=82aw?= Wojnowski To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 11 21:27:06 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zwbyy-0008Mw-5r for ged-emacs-devel@m.gmane.org; Wed, 11 Nov 2015 21:27:04 +0100 Original-Received: from localhost ([::1]:42793 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwbyx-0004vE-W9 for ged-emacs-devel@m.gmane.org; Wed, 11 Nov 2015 15:27:04 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwbyu-0004v8-Pn for emacs-devel@gnu.org; Wed, 11 Nov 2015 15:27:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zwbyr-0000bu-KP for emacs-devel@gnu.org; Wed, 11 Nov 2015 15:27:00 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:7229) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwbyr-0000bf-GT for emacs-devel@gnu.org; Wed, 11 Nov 2015 15:26:57 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DCEQA731xV/8uQWxdcgxCEAoVVu0CHUQKBPTkTAQEBAQEBAYEKQQWDXQEBAwF5BQsLDScSFBiIaAjPIwEBAQcCAR+LOoUFBxaEFwWMMJJnhl4LjwQjggkdgXAggngBAQE X-IPAS-Result: A0DCEQA731xV/8uQWxdcgxCEAoVVu0CHUQKBPTkTAQEBAQEBAYEKQQWDXQEBAwF5BQsLDScSFBiIaAjPIwEBAQcCAR+LOoUFBxaEFwWMMJJnhl4LjwQjggkdgXAggngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="177818328" Original-Received: from unknown (HELO pastel.home) ([23.91.144.203]) by ironport2-out.teksavvy.com with ESMTP; 11 Nov 2015 15:26:55 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id E1283601DD; Wed, 11 Nov 2015 15:26:53 -0500 (EST) In-Reply-To: (Nicolas Petton's message of "Wed, 11 Nov 2015 16:56:03 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194134 Archived-At: > New file with obarray functions. > * lisp/obarray.el: basic obarray functions extracted from abbrev.el > * test/automated/obarray-tests.el: new file Funnily enough, I think we should discourage the use of obarrays. There are times/places where they are really indispensable (when we really need to handle *symbols*), but in the majority of cases where I could see this obarray.el being used, a hash-table would work better (e.g. hash-table-p is more reliable, print+read actually works, access is usually faster, ...). Stefan