From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] fix/undo-point-in-wrong-place 3e18fc2: Store point and buffer in independent variables. Date: Thu, 26 Nov 2015 08:05:45 -0500 Message-ID: References: <20151126102244.16252.97125@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1448543181 16341 80.91.229.3 (26 Nov 2015 13:06:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 26 Nov 2015 13:06:21 +0000 (UTC) Cc: Phillip Lord To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 26 14:06:10 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a1wFS-0001DC-S7 for ged-emacs-devel@m.gmane.org; Thu, 26 Nov 2015 14:06:07 +0100 Original-Received: from localhost ([::1]:51136 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1wFU-00047E-V4 for ged-emacs-devel@m.gmane.org; Thu, 26 Nov 2015 08:06:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1wFE-00046Z-Hx for emacs-devel@gnu.org; Thu, 26 Nov 2015 08:05:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1wF9-0008Nk-IK for emacs-devel@gnu.org; Thu, 26 Nov 2015 08:05:52 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:7677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1wF9-0008NT-BI for emacs-devel@gnu.org; Thu, 26 Nov 2015 08:05:47 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0B8HgA731xV/yr292hcgxCEAsEMCYdLBAICgTw5FAEBAQEBAQGBCkEBAgKDXQEBBFYjEAs0BwsUGA2IY88jAQEIAQEBAR6LOoUFBxaEFwWMMJJng2uSAiOCO4FbIIJ4AQEB X-IPAS-Result: A0B8HgA731xV/yr292hcgxCEAsEMCYdLBAICgTw5FAEBAQEBAQGBCkEBAgKDXQEBBFYjEAs0BwsUGA2IY88jAQEIAQEBAR6LOoUFBxaEFwWMMJJng2uSAiOCO4FbIIJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="179454081" Original-Received: from 104-247-246-42.cpe.teksavvy.com (HELO fmsmemgm.homelinux.net) ([104.247.246.42]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 26 Nov 2015 08:05:46 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 84EB6AE067; Thu, 26 Nov 2015 08:05:45 -0500 (EST) In-Reply-To: (Phillip Lord's message of "Thu, 26 Nov 2015 10:22:44 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195279 Archived-At: The change looks fine this time. > -extern ptrdiff_t last_point_position; > +ptrdiff_t point_before_last_command_or_undo; > +struct buffer *buffer_before_last_command_or_undo; But please add a comment describing precisely what those variables hold. Stefan