* Re: [Emacs-diffs] fix/undo-point-in-wrong-place 3e18fc2: Store point and buffer in independent variables.
[not found] ` <E1a1thM-0004Ek-Rm@vcs.savannah.gnu.org>
@ 2015-11-26 13:05 ` Stefan Monnier
0 siblings, 0 replies; only message in thread
From: Stefan Monnier @ 2015-11-26 13:05 UTC (permalink / raw)
To: emacs-devel; +Cc: Phillip Lord
The change looks fine this time.
> -extern ptrdiff_t last_point_position;
> +ptrdiff_t point_before_last_command_or_undo;
> +struct buffer *buffer_before_last_command_or_undo;
But please add a comment describing precisely what those variables hold.
Stefan
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-11-26 13:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151126102244.16252.97125@vcs.savannah.gnu.org>
[not found] ` <E1a1thM-0004Ek-Rm@vcs.savannah.gnu.org>
2015-11-26 13:05 ` [Emacs-diffs] fix/undo-point-in-wrong-place 3e18fc2: Store point and buffer in independent variables Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).