From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 db436e9: Don't call debug on failed cl-assert Date: Tue, 08 Nov 2016 08:17:23 -0500 Message-ID: References: <20161105015720.6371.89806@vcs.savannah.gnu.org> <20161105015720.88A6322012D@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1478611354 11930 195.159.176.226 (8 Nov 2016 13:22:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 8 Nov 2016 13:22:34 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 08 14:22:31 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c46LX-0006FW-0M for ged-emacs-devel@m.gmane.org; Tue, 08 Nov 2016 14:21:51 +0100 Original-Received: from localhost ([::1]:32958 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c46LZ-0000sn-Il for ged-emacs-devel@m.gmane.org; Tue, 08 Nov 2016 08:21:53 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c46Kg-0000sD-Ny for emacs-devel@gnu.org; Tue, 08 Nov 2016 08:21:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c46Kc-0005k5-Nw for emacs-devel@gnu.org; Tue, 08 Nov 2016 08:20:58 -0500 Original-Received: from [195.159.176.226] (port=47979 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c46Kc-0005ja-CI for emacs-devel@gnu.org; Tue, 08 Nov 2016 08:20:54 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1c46Jo-0002o4-Gf for emacs-devel@gnu.org; Tue, 08 Nov 2016 14:20:04 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 19 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:1+VyqiTp4Ygj//gJRMwFV2y1fAI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209280 Archived-At: >> Not if the code is run within an `ignore-errors` clause or some other >> condition-case catching `error`. > Hmm, this seems like kind of a kludgy way to circumvent ignore-errors. It's not perfect, indeed. > Wouldn't it better to use > (setq debug-on-error '(cl-assertion-failed) debug-on-signal t) along with: But I want debug-on-error to be t, so setting debug-on-signal non-nil is not an option because it's too invasive. Another option would be to declare that the `cl-assertion-failed` signal does not have `error` as its parent, so ignore-errors wouldn't catch it. But really, this should only be the case when debug-on-error is non-nil, which is rather problematic. Stefan