From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 9bf66c6: Don't run FOR_EACH_FRAME when there's no frame left (Bug#29961) Date: Fri, 15 Dec 2017 11:23:31 -0500 Message-ID: References: <20171215073120.7671.79446@vcs0.savannah.gnu.org> <20171215073122.52703204D3@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1513355030 22580 195.159.176.226 (15 Dec 2017 16:23:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 15 Dec 2017 16:23:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Martin Rudalics To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 15 17:23:47 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePsm3-0005ae-1u for ged-emacs-devel@m.gmane.org; Fri, 15 Dec 2017 17:23:47 +0100 Original-Received: from localhost ([::1]:47445 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePsmA-0006kK-7P for ged-emacs-devel@m.gmane.org; Fri, 15 Dec 2017 11:23:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePsly-0006iX-Lz for emacs-devel@gnu.org; Fri, 15 Dec 2017 11:23:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePslt-0004vf-LQ for emacs-devel@gnu.org; Fri, 15 Dec 2017 11:23:42 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:43351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePslt-0004ux-Gi for emacs-devel@gnu.org; Fri, 15 Dec 2017 11:23:37 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id vBFGNWkX014146; Fri, 15 Dec 2017 11:23:32 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id E355EAE0F1; Fri, 15 Dec 2017 11:23:31 -0500 (EST) In-Reply-To: <20171215073122.52703204D3@vcs0.savannah.gnu.org> (Martin Rudalics's message of "Fri, 15 Dec 2017 02:31:20 -0500 (EST)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6181=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6181> : inlines <6254> : streams <1773200> : uri <2551650> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221103 Archived-At: > - FOR_EACH_FRAME (tail, frame) > - free_glyphs (XFRAME (frame)); > + if (!NILP (Vframe_list)) > + FOR_EACH_FRAME (tail, frame) > + free_glyphs (XFRAME (frame)); I don't understand: #define FOR_EACH_FRAME(list_var, frame_var) \ for ((list_var) = (eassume (CONSP (Vframe_list)), Vframe_list); \ (CONSP (list_var) \ && (frame_var = XCAR (list_var), true)); \ list_var = XCDR (list_var)) So, if Vframe_list is Qnil, the `CONSP (list_var)` test should make us exit the loop right from the start. Is the problem caused by eassume (CONSP (Vframe_list))? If so, maybe we should simply remove it. Stefan