unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Martin Rudalics <rudalics@gmx.at>
Subject: Re: [Emacs-diffs] emacs-26 9bf66c6: Don't run FOR_EACH_FRAME when there's no frame left (Bug#29961)
Date: Fri, 15 Dec 2017 11:23:31 -0500	[thread overview]
Message-ID: <jwvwp1oezdc.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20171215073122.52703204D3@vcs0.savannah.gnu.org> (Martin Rudalics's message of "Fri, 15 Dec 2017 02:31:20 -0500 (EST)")

> -  FOR_EACH_FRAME (tail, frame)
> -    free_glyphs (XFRAME (frame));
> +  if (!NILP (Vframe_list))
> +    FOR_EACH_FRAME (tail, frame)
> +      free_glyphs (XFRAME (frame));
 
I don't understand:

    #define FOR_EACH_FRAME(list_var, frame_var)     \
      for ((list_var) = (eassume (CONSP (Vframe_list)), Vframe_list); \
           (CONSP (list_var)                        \
            && (frame_var = XCAR (list_var), true)); \
           list_var = XCDR (list_var))

So, if Vframe_list is Qnil, the `CONSP (list_var)` test should make us
exit the loop right from the start.

Is the problem caused by eassume (CONSP (Vframe_list))?
If so, maybe we should simply remove it.


        Stefan



       reply	other threads:[~2017-12-15 16:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20171215073120.7671.79446@vcs0.savannah.gnu.org>
     [not found] ` <20171215073122.52703204D3@vcs0.savannah.gnu.org>
2017-12-15 16:23   ` Stefan Monnier [this message]
2017-12-15 17:13     ` [Emacs-diffs] emacs-26 9bf66c6: Don't run FOR_EACH_FRAME when there's no frame left (Bug#29961) Paul Eggert
2017-12-15 18:17       ` martin rudalics
2017-12-15 19:09         ` Paul Eggert
2017-12-16  9:42           ` martin rudalics
2017-12-17  0:50             ` Paul Eggert
2017-12-17 10:46               ` martin rudalics
2017-12-18  0:39                 ` Paul Eggert
2017-12-18  7:26                   ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvwp1oezdc.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).