From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Patch] Enable byte-compile-error-on-wran for error-free files in lisp/ Date: Thu, 22 Feb 2018 00:24:37 -0500 Message-ID: References: <87o9kii4an.fsf@cochranmail.com> <87371tn2qg.fsf@cochranmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1519277019 27275 195.159.176.226 (22 Feb 2018 05:23:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 22 Feb 2018 05:23:39 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Robert Cochran Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 22 06:23:35 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eojLy-0006hz-Og for ged-emacs-devel@m.gmane.org; Thu, 22 Feb 2018 06:23:34 +0100 Original-Received: from localhost ([::1]:36183 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eojO1-0001DO-2c for ged-emacs-devel@m.gmane.org; Thu, 22 Feb 2018 00:25:41 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eojNv-0001D3-42 for emacs-devel@gnu.org; Thu, 22 Feb 2018 00:25:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eojNr-0001rS-68 for emacs-devel@gnu.org; Thu, 22 Feb 2018 00:25:35 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:38268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eojNq-0001pj-OV for emacs-devel@gnu.org; Thu, 22 Feb 2018 00:25:31 -0500 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w1M5Ob2K028484; Thu, 22 Feb 2018 00:24:38 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 66EEA663FA; Thu, 22 Feb 2018 00:24:37 -0500 (EST) In-Reply-To: <87371tn2qg.fsf@cochranmail.com> (Robert Cochran's message of "Wed, 21 Feb 2018 19:05:11 -0800") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6227=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6227> : inlines <6424> : streams <1779686> : uri <2597197> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222979 Archived-At: > I am trying to keep warnings from lingering. The > string-{to,as}-{multi,uni}byte family of functions have been deprecated > since June 2016, which are some of the functions I see the most in the > deprecation warnings. Stuff like that. Indeed, these turn out to be difficult to fix: - the potential replacement code is subtly different and it usually requires a detailed understanding of the code to know what's the right fix. - in many places those function calls were added when Emacs's handling of `eight-bit` chars was different and it's difficult to know how that's affected by subsequent changes. - there are various situations where there's no really good replacement. I guess that means that while they are marked as obsolete we really won't be getting rid of them any time soon. And we can probably just silence the remaining warnings with `with-no-warnings` but only after we clearly document the need to use this function and what it would need to do otherwise. > Hmm, sounds like its better to just not do that with files distributed > in parallel. I don't have a problem with that (most files is better than > no files after all), but I have no idea which ones are and are not 'core > only' files. Guidance requested. Good question. After contributing to Emacs for almost 20 years I generally "just know", but it's not 100% and it's not written down anywhere for those who don't have that 20 year head start. I agree it would be useful to document it. Eli, John, any idea what would be the best way to document those things? Should we just add a "Unbundled: yes" to the pseudo-headers, or maybe just (ab)use the typical "URL: ..." pseudo-header for that? As for which files are affected, I can't remember offhand, but a first approximation is: org/*, mh-e/*, cc-*, vhdl and verilog, antlr and those files mentioned in elpa.git/externals-list? Stefan