unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* highlight-indent-guides in display engine
@ 2019-07-06 21:17 Ergus
  2019-07-07 15:04 ` Eli Zaretskii
  0 siblings, 1 reply; 25+ messages in thread
From: Ergus @ 2019-07-06 21:17 UTC (permalink / raw)
  To: emacs-devel

Hi guys:

This email is a question about the highlight-indent-guides because some
people find that functionality very useful (and it is very common in
ides/editors around).

I am using the package with that name [1] but It affects performance a
lot. Specially scrolling and responsiveness in general. Even when
disabling the animations. 

So my question is in two parts:

1) Does emacs already provides a way to reproduce this functionality
that does not kill performance so much, even if we sacrifice some
functionality?

else:

2) Does it make sense to implement it in the display engine as we did
with the fill-column-indicator?

Thanks in advance for your replies,
Ergus

[1]: https://github.com/DarthFennec/highlight-indent-guides



^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: highlight-indent-guides in display engine
@ 2019-07-07 17:50 Keith David Bershatsky
  0 siblings, 0 replies; 25+ messages in thread
From: Keith David Bershatsky @ 2019-07-07 17:50 UTC (permalink / raw)
  To: Emacs Devel; +Cc: Ergus, Eli Zaretskii

[-- Attachment #1: Type: text/plain, Size: 97 bytes --]

I forgot to cc Emacs Devel ...

;;;;;;;;;;;;;;;;;;;;;; FORWARDED MESSAGE ;;;;;;;;;;;;;;;;;;;;;;


[-- Attachment #2: Type: message/rfc822, Size: 1122 bytes --]

From: Keith David Bershatsky <esq@lawlist.com>
To: Ergus <spacibba@aol.com>,Eli Zaretskii <eliz@gnu.org>
Subject: Re: highlight-indent-guides in display engine
Date: Sun, 07 Jul 2019 10:48:51 -0700
Message-ID: <m2wogtd9bw.wl%esq@lawlist.com>

I would suggest devising a method capable of intersecting characters, e,g.,

https://www.lawlist.com/images/22873_17684_light_dark_backgrounds.png

Using features 17684/22873, Emacs can quickly generate up to three lines that are capable of intersecting characters ...  The current draft patch is version 021.004 [06/29/2019]:

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22873#155

Using features 17684/22873, I have not run any tests to see how many vertical lines could be drawn before there is an appreciable performance hit.  The current design only redraws what has changed since the previous redisplay, so it may be possible to draw several vertical lines without any performance hit at all ...

One idea that I have not tried would be to use a thin window like a scroll bar window to draw a vertical line ...

^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2019-07-16  8:06 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-06 21:17 highlight-indent-guides in display engine Ergus
2019-07-07 15:04 ` Eli Zaretskii
2019-07-11 19:06   ` Ergus
2019-07-11 19:15     ` Eli Zaretskii
2019-07-12  0:21       ` Ergus
2019-07-12  6:57         ` Eli Zaretskii
2019-07-12  9:58           ` Ergus
2019-07-12 10:36             ` Ergus
2019-07-12 13:45             ` Eli Zaretskii
2019-07-12 18:51               ` Ergus
2019-07-12 19:35                 ` Drew Adams
2019-07-13  6:59                 ` Eli Zaretskii
2019-07-13  8:32                   ` Joost Kremers
2019-07-13  8:38                     ` Eli Zaretskii
2019-07-13 21:37                       ` Joost Kremers
2019-07-14  5:37                         ` Eli Zaretskii
2019-07-15  5:44                           ` Joost Kremers
2019-07-14 12:56                         ` Ergus
2019-07-15 12:58                           ` Stefan Monnier
2019-07-15 14:11                             ` Ergus
2019-07-15 14:49                               ` Stefan Monnier
2019-07-15 17:10                                 ` Ergus
2019-07-15 18:43                                   ` Stefan Monnier
2019-07-16  8:06                                     ` Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2019-07-07 17:50 Keith David Bershatsky

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).