From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: BIKESHED: completion faces Date: Sat, 26 Oct 2019 21:58:14 -0400 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="163676"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 27 02:59:08 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iOXpi-000gPM-SC for ged-emacs-devel@m.gmane.org; Sun, 27 Oct 2019 02:59:07 +0100 Original-Received: from localhost ([::1]:43756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOXph-0001is-3B for ged-emacs-devel@m.gmane.org; Sat, 26 Oct 2019 21:59:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48855) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOXp5-0001g0-Gn for emacs-devel@gnu.org; Sat, 26 Oct 2019 21:58:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iOXp2-0006KO-3i for emacs-devel@gnu.org; Sat, 26 Oct 2019 21:58:26 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19175) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iOXp1-0006KC-Tj for emacs-devel@gnu.org; Sat, 26 Oct 2019 21:58:24 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BACEF10032F; Sat, 26 Oct 2019 21:58:22 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E7F321002E2; Sat, 26 Oct 2019 21:58:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1572141500; bh=cuvZsmvDmZR6Fux2zBq2MtASu1C6c7NwdQ7Mq4OwgYY=; h=From:To:Subject:Date:From; b=dWSDmsgJpgqpgeyF8weyQ/Snqis2Y3fJQ7owh9iK5ItMFm5x6c+wnlaE0kohs9Eeg C1+xAb+q9yJB8nAlwjTKqi5adkKNaGYnygXUuxozYkRHXdxGtGwdQd5YGDzKOxhO6O agLkmbERby6N72NyEHSxbgyh6NADFcwT/MxdQlUKNI69GQkoVBa7AlJg5ZIGabKEsz dr0olgA+BE3ChTldN1ISZlDi4BZwBMuzFHEEQ2geUVktRMR/ucQWoCsda1c+MBLD2g AAjpeW3lPgUQxp6FEA5LamHNkE40Sh2wEiWJ/00h3NnSc4OHTZYGkxS4FipGXGMhQG U4SnZWSUJw/Cg== Original-Received: from pastel (unknown [216.154.37.243]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 474A2120655; Sat, 26 Oct 2019 21:58:20 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241493 Archived-At: In Emacs-26, completion faces looked like the following: - the "common" part shown like the default face. - the "first-difference" shown in bold. - everything else uses the default face. The "common" part is the part applied to the characters that are also found in the current minibuffer. E.g. when completing M-x ne-li ? the "ne" and "-li" chars in the *Completions* are the "common" part. With the basic, prefix completion, the "common" part is not very important and is separated from the rest at the "first-difference", so the default faces make a fair bit of sense there. But for other completion styles such as `substring`, `partial-completion`, and even more so for `flex`, it's not always immediately obvious how the minibuffer contents relate to the possible completions displayed in *Completions*. For this reason, it is common in other completion systems to highlight the "common" part somehow (e.g. underline, bold, ...). I think Emacs's defaults should be changed so that the "common" part (which uses the `completions-common-part` face) is highlighted somehow. So, what should we go for: - bold (but then we need to change the `completions-first-difference` face to keep it different, e.g. underlined)? - underlined (tho I don't like underlined text very much)? - some foreground color? - some background color? - something else? Stefan