From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: mouse-face and help echo support for xterm mouse Date: Sun, 01 Nov 2020 08:39:49 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3884"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Jared Finder To: Jared Finder via "Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 01 14:40:30 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZDaw-0000um-Nv for ged-emacs-devel@m.gmane-mx.org; Sun, 01 Nov 2020 14:40:30 +0100 Original-Received: from localhost ([::1]:46204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZDav-0004WM-QV for ged-emacs-devel@m.gmane-mx.org; Sun, 01 Nov 2020 08:40:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZDaN-00045P-QN for emacs-devel@gnu.org; Sun, 01 Nov 2020 08:39:55 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:13591) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZDaL-0002sl-JE for emacs-devel@gnu.org; Sun, 01 Nov 2020 08:39:54 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C42344408E0; Sun, 1 Nov 2020 08:39:51 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8E452440202; Sun, 1 Nov 2020 08:39:50 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1604237990; bh=5eEz7Mc80LPAjFNvVSzPzRZU1G595MOPpzKsWUegfp8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=CXvAhsWqfq3CC6Ufv9KadnBdtNh3dsj78fDdItssBsLUHdUq+SbBtKz2Jpv16GU3T OvxN4eJwd/tY13gB+gaqQh88f7s3ipQAHBLRdK/sNVf6ohvrr1C2xKIslUtFuk3VrK LGUm2rKCysPytVrSUJliANvaBDZT34FRjmMsLUsPxiAlHKKy7tY2BknVxx7NajQkgg PdF1P+nBTt67TcLS/7KtIwowmLjK5oaWn/edatabA6wg/IRPfUxqygxdq2O0rHkTdn 4+vpmfQ8I6iB4Otk5rwV3epJwyUh7bGz6JpMQC+dfq9hkxY8G49x344lix8hUYnpyl cL4Wwrf0TLgtw== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5A5AD120310; Sun, 1 Nov 2020 08:39:50 -0500 (EST) In-Reply-To: (Jared Finder via's message of "Sat, 31 Oct 2020 22:46:32 -0700") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/01 08:29:12 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258599 Archived-At: Hi Jared, I really like this new feature but have just one comment/question? > + previous_help_echo_string = help_echo_string; > + help_echo_string = Qnil; > + > + note_mouse_highlight(XFRAME(frame), XFIXNUM (mouse_x), XFIXNUM (mouse_y)); > + > + if (!NILP (help_echo_string) > + || !NILP (previous_help_echo_string)) > + { > + gen_help_event (help_echo_string, frame, help_echo_window, > + help_echo_object, help_echo_pos); > + } I see this exact same code in other C files. Could we move it to a file where we can share it instead of having N copies? Stefan