From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: elisp--local-variables triggers an error on special input Date: Sat, 02 Jan 2021 21:47:22 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9730"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel To: Evgeny Zajcev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 03 03:48:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kvtRA-0002RG-Vg for ged-emacs-devel@m.gmane-mx.org; Sun, 03 Jan 2021 03:48:08 +0100 Original-Received: from localhost ([::1]:41418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvtRA-0002pq-0T for ged-emacs-devel@m.gmane-mx.org; Sat, 02 Jan 2021 21:48:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvtQX-0002PJ-Tx for emacs-devel@gnu.org; Sat, 02 Jan 2021 21:47:30 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:59654) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvtQV-00033D-3K for emacs-devel@gnu.org; Sat, 02 Jan 2021 21:47:28 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D91EB44095D; Sat, 2 Jan 2021 21:47:24 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 982A54408E8; Sat, 2 Jan 2021 21:47:23 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1609642043; bh=3+xcfnz5b0le0kB+Xkry9wHWgo4qpGBwmoKtv681MK4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Ov+jmbzZuBkFYpKdc2pyYwrxwSB6GoOjQDDNB4q3L60nxKrM9azG/KGlhU2EP1EbG k2ykSXAGpkO1EOHMgWfC1YWM0Ik/4H7SLY6cgI8sLM7B9Ca68+z7+bpChkOmN2Ekd5 T8io7Eifeq3LWzSmniNLBHHAyQIg76OqorMGgDekse66w7lniiYF+gNN6ro5g6JH0p ClwqnkMpDViMM5szUCE+l+26/fJBGymND4a2tkDPumOUe0lTcl2I8OETLcTR2KNMgp T2yUXr+ejNPuHXOa/hkSGU52kVpLlp1CAqWQF5T8WKIkp/dRMgHQ2Q+BebOd+a+Wk7 uph8zOURHbYBg== Original-Received: from alfajor (unknown [104.247.243.191]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 145F712036E; Sat, 2 Jan 2021 21:47:23 -0500 (EST) In-Reply-To: (Evgeny Zajcev's message of "Tue, 29 Dec 2020 10:06:19 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262340 Archived-At: > In these cases lisp syntax is ok, but `elisp--local-variables-1' fails on > it: > > (with-current-buffer (get-buffer-create "bb") > (erase-buffer) > (insert "(let cc ") > (elisp--local-variables)) > ==> Lisp error: (wrong-type-argument listp cc) > > (with-current-buffer (get-buffer-create "bb") > (erase-buffer) > (insert "(let [a b]\n") > (elisp--local-variables)) > ==> Lisp error: (wrong-type-argument listp [a b]) > > Should we fix all these cases one by one, I think we should try to, yes. > or maybe just run `elisp--local-variables` under `ignore-errors`, what > do you think? I think it's best to let the caller ignore (or demote) errors if it wants to. Stefan