From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 1559cc4: Fix missing file&line info in "Unknown defun property" warnings Date: Sat, 23 Jan 2021 17:46:39 -0500 Message-ID: References: <20210123210445.12536.65283@vcs0.savannah.gnu.org> <20210123210447.45FA120AD1@vcs0.savannah.gnu.org> <87y2gjz46n.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14698"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 23 23:47:47 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3Rh4-0003kP-LY for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 23:47:46 +0100 Original-Received: from localhost ([::1]:52284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3Rh3-00050z-Km for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 17:47:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3Rg6-0004Xb-Tl for emacs-devel@gnu.org; Sat, 23 Jan 2021 17:46:46 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61424) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3Rg4-0004d5-7l for emacs-devel@gnu.org; Sat, 23 Jan 2021 17:46:45 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D33AB441003; Sat, 23 Jan 2021 17:46:42 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3036E441010; Sat, 23 Jan 2021 17:46:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1611442001; bh=fHVfogBQvR5AmEA0xY7looREP9nOaaP3WXjCVrUe9X4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ozSsKLQJEsWbF6I2Zv+RH5TPsmh/waygGZKi3Scs3J7BmotWfuL4TgM+wrGzzWJMu ygur6J85AcBfVp7p/bIwlucz7yIQLGv/VoFAI8I0EN83bN1sOm5CYT2OndimDKHicz QCGwztaUnD7ODXOEN9etmZYM+Sxli6hMQbBKi+XEOhzv3xUnNRsHGYAtFFJeGZVUF2 PCgZZ4TJ6d5Q8xHoDzHdd912BMfs7A6JF26AmESy1lylESNIYWoU9uL7BNGDY9De02 jnl8k8b6FSyz33P2jfuTXKfE/Fy7ataVh3o7TLrqDzwJKvsx/9SygHFSpuq1ahgtwl jGMPWmeEI29dw== Original-Received: from alfajor (65-110-220-188.cpe.pppoe.ca [65.110.220.188]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E94651201F1; Sat, 23 Jan 2021 17:46:40 -0500 (EST) In-Reply-To: <87y2gjz46n.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 23 Jan 2021 22:20:00 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263325 Archived-At: > diff --git a/test/lisp/autorevert-tests.el b/test/lisp/autorevert-tests.el > index 683e3ea30d..19d9f7b13f 100644 > --- a/test/lisp/autorevert-tests.el > +++ b/test/lisp/autorevert-tests.el > @@ -609,11 +609,12 @@ auto-revert-test07-auto-revert-several-buffers > (should auto-revert-mode)) =20 > (dotimes (i num-buffers) > - (add-to-list > - 'buffers > - (make-indirect-buffer > - (car buffers) (format "%s-%d" (buffer-file-name (car buff= ers)) i) 'clone) > - 'append)) > + (let ((buf (make-indirect-buffer > + (car buffers) > + (format "%s-%d" (buffer-file-name (car buffers)= ) i) > + 'clone))) > + (unless (memq buf buffers) > + (setq buffers (nconc buffers (list buf)))))) This looks like it will do what the old code did, yes. We can do better, tho: - the `make-indirect-buffer` will returna fresh new buffer, so `memq` will always return nil. - the `nconc` gives an over O(n=B2) complexity which is not justified. so I'd recommend (dotimes (i num-buffers) (push (make-indirect-buffer (car buffers) (format "%s-%d" (buffer-file-name (car buffers)) i) 'clone) buffers)) (setq buffer (nreverse buffers)) instead. I think the same applies to the second loop in autorevert-tests.e= l. Also in `test-seq-random-elt-take-all` you can use `cl-pushnew` instead of the or+memq+push. Stefan