From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master ae7fe26 1/3: ; Fix my previous commit Date: Fri, 29 Jan 2021 00:09:31 -0500 Message-ID: References: <20210128210843.30971.34738@vcs0.savannah.gnu.org> <20210128210845.9436B20B72@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36042"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 29 06:13:47 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5M6N-0009Gp-5p for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Jan 2021 06:13:47 +0100 Original-Received: from localhost ([::1]:38234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5M6M-0001Uc-8X for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Jan 2021 00:13:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5M2Z-0005yp-EM for emacs-devel@gnu.org; Fri, 29 Jan 2021 00:09:51 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46444) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5M2V-0004ud-97 for emacs-devel@gnu.org; Fri, 29 Jan 2021 00:09:49 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F3F16805B2; Fri, 29 Jan 2021 00:09:44 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5234E801E9; Fri, 29 Jan 2021 00:09:39 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1611896979; bh=bXJqUdmBO5clYS2w9/u6AHyH8vHajDwgS2Snlib9iYo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=cts6wPC/c0C2KXf64FOY5LKF8A6qxBbLqW4yPEF2kQKeY82eC/8RPoD+ymtSHEPv9 ckcP8MvgKV4X60J6svV7m3d10Vr3hswM0z+Jqty5okGvz7oCzJZIr4sJz3On06e3Ae grJgkhNQesKX0CNQ5lufjVGxbYT6+VKh5QZuDOLXu9JjjvxEbEOEw4rG0jPgVfDo/r BVsqOvDf0e5TNMGlgVxxVNQr/GRohAcG17eH7p0oaYDWP5BBCxOPod1+XByXH9CfWW PqoDDOtbbNGJcb8WfcM+iDZBB/KcM7UDNKCU0S8C5U+mCHoflk86n9f/VHpuEnJQRM cAo4F39fsTcvw== Original-Received: from alfajor (69-196-141-46.dsl.teksavvy.com [69.196.141.46]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2170312022C; Fri, 29 Jan 2021 00:09:39 -0500 (EST) In-Reply-To: (Stefan Kangas's message of "Thu, 28 Jan 2021 20:19:14 -0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263569 Archived-At: >> The problem is that most of the `defun`s in this file are not at top >> level but inside a `when`. This is ugly and should be fixed. > Yes, that was my diagnosis as well. I suppose one could argue that this > warning is a bug, It's definitely a limitation that occasionally gets in the way. > BTW, is there any reason why the modes in generic-x.el are not > autoloaded and in auto-mode-alist? I did not know that (require > 'generic-x) was a thing until today, and I do remember at times missing > the syntax highlighting of some of the files it supports. Probably because they're all pretty lame? I think they should all be rewritten to use define-derived-mode and generic.el should then be marked obsolete. But this requires first providing some way to set the comment syntax more-or-less as conveniently as done with define-generic-mode. Stefan